reduced frequency of session timestamp update

Author: Richard Jones

CHANGES.txt

@@ -16,6 +16,7 @@ Fixed:
 - escape *all* uses of "schema" in mysql backend (sf bug 1472120)
 - responses to user rego email (sf bug 1470254)
 - dangling connections in session handling (sf bug 1463359)
+- reduced frequency of session timestamp update
 
 
 2006-03-03 1.1.1

roundup/backends/sessions_dbm.py

@@ -1,4 +1,4 @@
-#$Id: sessions_dbm.py,v 1.5 2004-03-31 23:08:38 richard Exp $
+#$Id: sessions_dbm.py,v 1.6 2006-04-27 04:03:11 richard Exp $
 """This module defines a very basic store that's used by the CGI interface
 to store session and one-time-key information.
 
@@ -131,7 +131,11 @@ def close(self):
         pass
 
     def updateTimestamp(self, sessid):
-        self.set(sessid, __timestamp=time.time())
+        ''' don't update every hit - once a minute should be OK '''
+        sess = self.get(sessid, '__timestamp', None)
+        now = time.time()
+        if sess is None or now > sess + 60:
+            self.set(sessid, __timestamp=now)
 
     def clean(self, now):
         """Age sessions, remove when they haven't been used for a week.

roundup/backends/sessions_rdbms.py

@@ -1,4 +1,4 @@
-#$Id: sessions_rdbms.py,v 1.3 2004-05-02 23:16:05 richard Exp $
+#$Id: sessions_rdbms.py,v 1.4 2006-04-27 04:03:11 richard Exp $
 """This module defines a very basic store that's used by the CGI interface
 to store session and one-time-key information.
 
@@ -77,9 +77,12 @@ def destroy(self, infoid):
             self.name, self.db.arg), (infoid,))
 
     def updateTimestamp(self, infoid):
-        self.cursor.execute('update %ss set %s_time=%s where %s_key=%s'%(
-            self.name, self.name, self.db.arg, self.name, self.db.arg),
-            (time.time(), infoid))
+        ''' don't update every hit - once a minute should be OK '''
+        now = time.time()
+        self.cursor.execute('''update %ss set %s_time=%s where %s_key=%s
+            and %s_time < %s'''%(self.name, self.name, self.db.arg,
+            self.name, self.db.arg, self.name, self.db.arg),
+            (now, infoid, now-60))
 
     def clean(self, now):
         """Age sessions, remove when they haven't been used for a week.

roundup/cgi/client.py

@@ -1,4 +1,4 @@
-# $Id: client.py,v 1.224 2006-04-27 03:48:41 richard Exp $
+# $Id: client.py,v 1.225 2006-04-27 04:03:11 richard Exp $
 
 """WWW request handler (also used in the stand-alone server).
 """
@@ -466,8 +466,8 @@ def determine_user(self):
             try:
                 # update the lifetime datestamp
                 sessions.updateTimestamp(self.session)
-                user = sessions.get(self.session, 'user')
                 self.db.commit()
+                user = sessions.get(self.session, 'user')
             except KeyError:
                 # not valid, ignore id
                 pass