Skip to content

Commit 75a99b9

Browse files
author
Richard Jones
committed
dangling connections in session handling [SF#1463359]
1 parent 1c98490 commit 75a99b9

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

CHANGES.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ Fixed:
1515
- verbose output during import is optional now (sf bug 1475624)
1616
- escape *all* uses of "schema" in mysql backend (sf bug 1472120)
1717
- responses to user rego email (sf bug 1470254)
18+
- dangling connections in session handling (sf bug 1463359)
1819

1920

2021
2006-03-03 1.1.1

roundup/cgi/client.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# $Id: client.py,v 1.223 2006-02-12 11:00:23 a1s Exp $
1+
# $Id: client.py,v 1.224 2006-04-27 03:48:41 richard Exp $
22

33
"""WWW request handler (also used in the stand-alone server).
44
"""
@@ -458,15 +458,16 @@ def determine_user(self):
458458
user = username
459459

460460
# if user was not set by http authorization, try session cookie
461-
if (not user) and self.cookie.has_key(self.cookie_name) \
462-
and (self.cookie[self.cookie_name].value != 'deleted'):
461+
if (not user and self.cookie.has_key(self.cookie_name)
462+
and (self.cookie[self.cookie_name].value != 'deleted')):
463463
# get the session key from the cookie
464464
self.session = self.cookie[self.cookie_name].value
465465
# get the user from the session
466466
try:
467467
# update the lifetime datestamp
468468
sessions.updateTimestamp(self.session)
469469
user = sessions.get(self.session, 'user')
470+
self.db.commit()
470471
except KeyError:
471472
# not valid, ignore id
472473
pass

0 commit comments

Comments
 (0)