Skip to content

Commit 220a1fe

Browse files
author
Richard Jones
committed
fix permission check on RetireAction [SF#1407342]
1 parent 94851e8 commit 220a1fe

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

CHANGES.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ Fixed:
5252
- fix admin doc description of roundup-server config file
5353
- fix redirect after instant registration (sf bug 1381676)
5454
- fix permission checks in cgi interface (sf bug 1289557)
55+
- fix permission check on RetireAction (sf bug 1407342)
5556

5657

5758
2005-10-07 0.8.5

doc/index.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,8 @@ Timothy J. Warren,
156156
William (Wilk),
157157
Tue Wennerberg,
158158
Matt Wilbert,
159-
Chris Withers.
159+
Chris Withers,
160+
Milan Zamazal.
160161

161162

162163

roundup/cgi/actions.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#$Id: actions.py,v 1.52 2006-01-13 03:56:36 richard Exp $
1+
#$Id: actions.py,v 1.53 2006-01-20 02:12:53 richard Exp $
22

33
import re, cgi, StringIO, urllib, Cookie, time, random, csv
44

@@ -124,6 +124,11 @@ def handle(self):
124124
self._('%(classname)s %(itemid)s has been retired')%{
125125
'classname': self.classname.capitalize(), 'itemid': nodeid})
126126

127+
def hasPermission(self, permission, classname=Action._marker, itemid=None):
128+
if itemid is None:
129+
itemid = self.nodeid
130+
return self.hasPermission(permission, classname, itemid)
131+
127132
class SearchAction(Action):
128133
name = 'search'
129134
permissionType = 'View'

0 commit comments

Comments
 (0)