classhelp works with Link properties now [SF#1410290]

Author: Richard Jones

CHANGES.txt

@@ -16,6 +16,7 @@ Feature:
 - enable registration confirmation by web only (sf bug 1381675)
 - allow preselection of values in templating menu()s (sf patch 1396085)
 - display the query name in the header (sf feature 1298535 / patch 1349387)
+- classhelp works with Link properties now (sf bug 1410290)
 
 Fixed:
 - MySQL now creates String columns using the TEXT column type

roundup/cgi/templating.py

@@ -625,7 +625,7 @@ def filter(self, request=None, filterspec={}, sort=(None,None),
 
     def classhelp(self, properties=None, label=''"(list)", width='500',
             height='400', property='', form='itemSynopsis',
-            pagesize=50, sort=None, filter=None):
+            pagesize=50, inputtype="checkbox", sort=None, filter=None):
         '''Pop up a javascript window with class help
 
         This generates a link to a popup window which displays the
@@ -648,6 +648,9 @@ def classhelp(self, properties=None, label=''"(list)", width='500',
 
         If the "property" arg is given, it's passed through to the
         javascript help_window function.
+        
+        You can use inputtype="radio" to display a radio box instead
+        of the default checkbox (useful for entering Link-properties)
 
         If the "form" arg is given, it's passed through to the
         javascript help_window function. - it's the name of the form
@@ -668,6 +671,8 @@ def classhelp(self, properties=None, label=''"(list)", width='500',
             property = '&property=%s'%property
         if form:
             form = '&form=%s'%form
+        if inputtype:
+            type= '&type=%s'%inputtype
         if filter:
             filterprops = filter.split(';')
             filtervalues = []
@@ -680,8 +685,8 @@ def classhelp(self, properties=None, label=''"(list)", width='500',
         else:
            filter = ''
         help_url = "%s?@startwith=0&@template=help&"\
-                   "properties=%s%s%s%s&@pagesize=%s%s" % \
-                   (self.classname, properties, property, form, sort, pagesize, filter)
+                   "properties=%s%s%s%s%s&@pagesize=%s%s" % \
+                   (self.classname, properties, property, form, type, sort, pagesize, filter)
         onclick = "javascript:help_window('%s', '%s', '%s');return false;" % \
                   (help_url, width, height)
         return '<a class="classhelp" href="%s" onclick="%s">%s</a>' % \

templates/classic/html/_generic.help.html

@@ -71,11 +71,12 @@
            <th tal:repeat="prop props" tal:content="prop" i18n:translate=""></th>
        </tr>
        <tr tal:repeat="item batch">
-           <tal:block tal:define="attr python:item[props[0]]">
-             <td>
-                 <input type="checkbox" name="check"
+         <tal:block tal:define="attr python:item[props[0]]" >
+           <td>
+             <input name="check"
                  onclick="updatePreview();"
-                 tal:attributes="value attr; id string:id_$attr" />
+                 tal:attributes="type python:request.form['type'].value;
+                                 value attr; id string:id_$attr" />
              </td>
              <td tal:repeat="prop props">
                  <label class="classhelp-label"

templates/minimal/html/_generic.help.html

@@ -71,11 +71,12 @@
            <th tal:repeat="prop props" tal:content="prop" i18n:translate=""></th>
        </tr>
        <tr tal:repeat="item batch">
-           <tal:block tal:define="attr python:item[props[0]]">
-             <td>
-                 <input type="checkbox" name="check"
+         <tal:block tal:define="attr python:item[props[0]]" >
+           <td>
+             <input name="check"
                  onclick="updatePreview();"
-                 tal:attributes="value attr; id string:id_$attr" />
+                 tal:attributes="type python:request.form['type'].value;
+                                 value attr; id string:id_$attr" />
              </td>
              <td tal:repeat="prop props">
                  <label class="classhelp-label"