Skip to content

Commit 08a1390

Browse files
committed
Fix arguments to 'menu cgi method
This would not work if more than one additional argument was used.
1 parent 91b6c6d commit 08a1390

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

CHANGES.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,9 @@ Fixed:
4242
- issue2550757: one bug raised by issue fixed. Patch created by
4343
W. Trevor King (wking) for documentation of mailgw applied by
4444
John Rouillard.
45+
- Fix processing of additional arguments to cgi method 'menu': This
46+
would not work if more than one additional argument is used.
47+
(Ralf Schlatterbeck)
4548

4649
2016-01-11: 1.5.1
4750

roundup/cgi/templating.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2073,11 +2073,11 @@ def menu(self, size=None, height=None, showid=0, additional=[], value=None,
20732073
if isinstance(prop, hyperdb.Link):
20742074
cl = self._db.getclass(prop.classname)
20752075
labelprop = cl.labelprop()
2076-
fn = lambda optionid, \
2076+
fn = lambda optionid, cl=cl, linkcl=linkcl, \
20772077
propname=propname, labelprop=labelprop: \
20782078
cl.get(linkcl.get(optionid, propname), labelprop)
20792079
else:
2080-
fn = lambda optionid, propname=propname: \
2080+
fn = lambda optionid, linkcl=linkcl, propname=propname: \
20812081
linkcl.get(optionid, propname)
20822082
additional_fns.append(fn)
20832083

@@ -2306,11 +2306,11 @@ def menu(self, size=None, height=None, showid=0, additional=[],
23062306
if isinstance(prop, hyperdb.Link):
23072307
cl = self._db.getclass(prop.classname)
23082308
labelprop = cl.labelprop()
2309-
fn = lambda optionid, \
2309+
fn = lambda optionid, cl=cl, linkcl=linkcl, \
23102310
propname=propname, labelprop=labelprop: \
23112311
cl.get(linkcl.get(optionid, propname), labelprop)
23122312
else:
2313-
fn = lambda optionid, propname=propname: \
2313+
fn = lambda optionid, linkcl=linkcl, propname=propname: \
23142314
linkcl.get(optionid, propname)
23152315
additional_fns.append(fn)
23162316

0 commit comments

Comments
 (0)