Skip to content

Commit 91b6c6d

Browse files
committed
Issue2407750 Add missing call to urllib.quote
Patch supplied by cedric_krier. Reviewed and applied by rouilj. "python run_tests.py -k 'not test_postgresql'" passed used for validation. Ran a demo.py run with some simple tests to index page. I don't have an explicit test to show that this patch fixes. However given the name of the function patched this looks likehowit should have been written originally.
1 parent 3a8d116 commit 91b6c6d

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

roundup/cgi/templating.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2695,7 +2695,8 @@ def indexargs_url(self, url, args):
26952695
"""
26962696
q = urllib.quote
26972697
sc = self.special_char
2698-
l = ['%s=%s'%(k,v) for k,v in args.items()]
2698+
l = ['%s=%s'%(k,isinstance(v, basestring) and q(v) or v)
2699+
for k,v in args.items()]
26992700

27002701
# pull out the special values (prefixed by @ or :)
27012702
specials = {}

0 commit comments

Comments
 (0)