Add option to hide horizon rings. #102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossengeorgiev
requested changes
Aug 29, 2020
| // "Position", | ||
| "1 hour", | ||
| "6 hours", | ||
| "12 hours", |
Owner
There was a problem hiding this comment.
To get a consistent experience on mobile, this list needs to be at most 6 entries, and entries need to match the backend code. It doesn't automatically handle arbitrary intervals
| if(follow_vehicle !== null) update_lookangles(follow_vehicle); | ||
| } | ||
|
|
||
|
|
Owner
There was a problem hiding this comment.
Can we combine these into a single function to hide/show the rings via a parameter for a single vehicle, and adjust other code to use it. There are two cases above when adding the position where you can simply reuse that new function
| <script type="text/javascript" language="javascript" src="js/nite-overlay.js"></script> | ||
| <script type="text/javascript" language="javascript" src="js/tracker.js"></script> | ||
| <script type="text/javascript" language="javascript" src="js/app.js"></script> | ||
| --> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the name suggests. This has been running on tracker.sondehub.org for a few months now.