Skip to content

Fix google tag manager snippet in wrong position (#80).#81

Closed
rvasquez-flip4new wants to merge 1 commit into
railslove:masterfrom
flip4dev:feature/80
Closed

Fix google tag manager snippet in wrong position (#80).#81
rvasquez-flip4new wants to merge 1 commit into
railslove:masterfrom
flip4dev:feature/80

Conversation

@rvasquez-flip4new

Copy link
Copy Markdown

Add possibility to render snippets in different positions.

Add possibility to render snippets in different positions.
@bumi

bumi commented Jun 9, 2017

Copy link
Copy Markdown
Contributor

Thanks a lot for your Pull Request. and sorry again that it took soooo long to look at this and get a new version out.
The PR was super valuable but we have changed the logic a bit and introduced a new method on the handler that allows the handler to directly manipulate the html response. This gives the handlers more flexibility for cases like the google tag manager requirements.
#84

The google tag manager is updated for that.
What do you think about that? Hope that helps? Are you still using rack-tracker?

@bumi bumi closed this Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants