Skip to content

Fix rails 5 depreciation warning#77

Closed
lilfaf wants to merge 1 commit intorailslove:masterfrom
Permigo:master
Closed

Fix rails 5 depreciation warning#77
lilfaf wants to merge 1 commit intorailslove:masterfrom
Permigo:master

Conversation

@lilfaf
Copy link
Copy Markdown

@lilfaf lilfaf commented Nov 3, 2016

Hi,

This is a just a simple fix to avoid warnings caused by env being depreciated in rails 5.1. We now have to access it through the request object.

Best regards

@DonSchado
Copy link
Copy Markdown
Collaborator

thanks, apparently it was already done: #71

but we need to support the older versions as well. can you take care of this?
(for some reason the travis build status is not visible here?)

@lilfaf
Copy link
Copy Markdown
Author

lilfaf commented Nov 4, 2016

oh my bad ! I didn't noticed PR #71. I'll try to fix the specs and ensure backward compatibility when I get some free time. 😉

@DonSchado
Copy link
Copy Markdown
Collaborator

thx again for raising this, we will finally take care of this in #82

@DonSchado DonSchado closed this Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants