Replace URI.escape with URI::DEFAULT_PARSER.escape#169
Open
r7kamura wants to merge 1 commit intorailslove:masterfrom
Open
Replace URI.escape with URI::DEFAULT_PARSER.escape#169r7kamura wants to merge 1 commit intorailslove:masterfrom
URI.escape with URI::DEFAULT_PARSER.escape#169r7kamura wants to merge 1 commit intorailslove:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses an issue where this library does not work properly on Ruby 3.0 or later.
URI.escapehas been deprecated since Ruby 3.0.There are several possible replacements, but the existing test cases expect half-width spaces to be converted into
%20. For that reason, I believeURI::DEFAULT_PARSER.escapeis the most appropriate in this situation.I ran this library’s test suite on Ruby 3.4 and confirmed that the test cases which had previously been failing now pass as a result of this change.