google global: better empty tracker handling

[glaszig]

i'm using the following code:

use Rack::Tracker do
  handler :google_global, trackers: [ { id: ENV["GA_ID"] } ], anonymize_ip: true
end

which throws up the following way if GA_ID is empty:

NoMethodError:
  undefined method `[]' for nil:NilClass
# ./lib/rack/tracker/google_global/template/google_global.erb:2:in `block in singleton class'
# ./lib/rack/tracker/google_global/template/google_global.erb:-2:in `instance_eval'
# ./lib/rack/tracker/google_global/template/google_global.erb:-2:in `singleton class'
# ./lib/rack/tracker/google_global/template/google_global.erb:-5:in `__tilt_70324565778440'
# ./lib/rack/tracker/handler.rb:37:in `render'
# ./lib/rack/tracker/handler.rb:50:in `block in inject'
# ./lib/rack/tracker/handler.rb:49:in `inject'
# ./lib/rack/tracker.rb:67:in `block in inject'
# ./lib/rack/tracker.rb:100:in `each'
# ./lib/rack/tracker.rb:100:in `each'
# ./lib/rack/tracker.rb:66:in `inject'
# ./lib/rack/tracker.rb:54:in `block in call'
# ./lib/rack/tracker.rb:54:in `call'
# ./spec/integration/google_global_integration_spec.rb:36:in `block (3 levels) in <top (required)>'

this patch properly handles the case of empty trackers in the templates and deals with a few other cases which should be considered "empty". also caches collected trackers in an ivar to save a few iterations and cleans up the integration test a little.

[bumi]

utACK
@DonSchado please merge, if you agree.

[bumi]

I think in the rest of the codebase we use parentheses.

[glaszig]

fixed.

[bumi]

thanks for the PR! 👍

[DonSchado]

I think that's a very good idea!
But shouldn't we use this chance to give a warning, instead of silently ignoring the tracker? :)

[DonSchado]

ping @glaszig :) is this still relevant?

[glaszig]

just added the warning.

[glaszig]

still a blocker? needs improvements? shall i squash the commits?

[DonSchado]

thanks for the reminder! :)