Allow to use custom pageview url script for GoogleAnalytics tracker.#119
Merged
DonSchado merged 2 commits intoJun 6, 2018
Conversation
Collaborator
|
Hey @Haerezis thanks for your pull request! 💚 |
Haerezis
force-pushed
the
feature/custom-google-analytics-pageview-script
branch
from
8b7fb6e to
cb4af06
Compare
Haerezis
force-pushed
the
feature/custom-google-analytics-pageview-script
branch
from
cb4af06 to
3939ee6
Compare
Contributor
Author
|
I've added the spec as requested. Sorry for not doing it directly, I just forgot :/ |
Contributor
|
nice! looks good to me and I think a good addition. thanks @Haerezis (note: I am not too familiar with the google analytics API) |
bumi
approved these changes
Jun 6, 2018
Collaborator
|
Thanks! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, we use your gem in our project and we need to track (with google analytics) the hash part of the url in the pageview event. We found a solution in this stackoverflow thread : https://stackoverflow.com/a/4813223 .
I have simply added the option to the Google Analytics tracker for a custom pageview url script (which default to the old and normal url script).
I'm at your disposal if you need anything.