Closed
Conversation
Collaborator
DonSchado
commented
Apr 27, 2018
DonSchado
commented
Collaborator
Author
|
I have the strong feeling |
bumi
approved these changes
May 26, 2018
Contributor
bumi
left a comment
bumi
left a comment
There was a problem hiding this comment.
sorry for the late comment.
👍 
Collaborator
Author
|
Oh, nearly forgot too... we need to adjust/write some specs first. I believe this is otherwise "broken" at the moment. 🤔 but have also no time at the moment to look into it |
Contributor
|
do we? specs are green, aren't they? |
Collaborator
Author
|
yes. because my bet is that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.