Skip to content

Support magic frozen string literal#116

Closed
DonSchado wants to merge 2 commits into
masterfrom
magic_frozen_string_literal
Closed

Support magic frozen string literal#116
DonSchado wants to merge 2 commits into
masterfrom
magic_frozen_string_literal

Conversation

@DonSchado

Copy link
Copy Markdown
Collaborator

297hzh

@DonSchado

Copy link
Copy Markdown
Collaborator Author

I have the strong feeling GoogleTagManager#inject is not well tested 🤔

@bumi bumi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the late comment.
👍 :shipit:

@DonSchado

Copy link
Copy Markdown
Collaborator Author

Oh, nearly forgot too... we need to adjust/write some specs first. I believe this is otherwise "broken" at the moment. 🤔 but have also no time at the moment to look into it

@bumi

bumi commented May 28, 2018

Copy link
Copy Markdown
Contributor

do we? specs are green, aren't they?

@DonSchado

Copy link
Copy Markdown
Collaborator Author

yes. because my bet is that GoogleTagManager#inject is not covered 😬

@DonSchado DonSchado closed this Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants