Recovery Reporting Changes #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 29, 2024 15:02
TheSkorm
commented
Jan 28, 2025
js/station.js
Outdated
|
|
||
| if (recovered) { | ||
| html += "<div><b>"+(recovery_info.recovered ? "Recovered by " : "Not Recovered by ")+recovery_info.recovered_by+"</u></b></div>"; | ||
| _recovered_text = recovery_info.recovered ? "Recovered by " : "Not Recovered by "; |
Member
Author
There was a problem hiding this comment.
There is xss vuln here. We shouldn't put user data into innerhtml.
TheSkorm
commented
Jan 28, 2025
|
|
||
| html += "<div style='line-height:16px;position:relative;'>"; | ||
| html += "<div><b><u>"+r[i].serial+(r[i].recovered ? " Recovered by " : " Not Recovered by ")+r[i].recovered_by+"</u></b></div>"; | ||
| html += "<div><b><u>"+r[i].serial+(_recovered_text)+r[i].recovered_by+"</u></b></div>"; |
TheSkorm
commented
Jan 28, 2025
| } | ||
|
|
||
| html = "<div style='line-height:16px;position:relative;'>"; | ||
| html += "<div><b>"+recovery.serial+(recovery.recovered ? " Recovered" : " Not Recovered")+"</b></div>"; |
TheSkorm
commented
Jan 28, 2025
js/sondehub.js
Outdated
| html += "<div><b>TX Frequency: </b>" + data.tx_frequency + " MHz</div>"; | ||
| } else if (data.hasOwnProperty("frequency")) { | ||
| html += "<div><b>Frequency: </b>" + data.frequency + " MHz</div>"; | ||
| html += "<div><b>Frequency: </b>" + data.frequency.toFixed(3) + " MHz</div>"; |
TheSkorm
commented
Jan 28, 2025
| } | ||
|
|
||
| var recovery_popup = true; | ||
| function recoveryPopup(){ |
Member
Author
There was a problem hiding this comment.
need to check if the map has loaded / recovery notice dom element exists yet before running this
TheSkorm
commented
Jan 28, 2025
TheSkorm
commented
Jan 28, 2025
TheSkorm
commented
Feb 9, 2025
index.template.html
Outdated
| </div> | ||
| <div class="row"> | ||
| <span> | ||
| <!--<input type="text" id="pr_notes" style="width: 140px;"/>--> |
Member
Author
There was a problem hiding this comment.
remove commented out code
js/sondehub.js
Outdated
| // Tile loads have changed. Update the store, and send the data. | ||
| last_sent_tile_loads = Object.assign({},tile_loads); | ||
| // // Check if the tile load count has changed. | ||
| // // Using JSON stringify is a bit of a hack, but appropriate for this kind of job. |
Member
Author
There was a problem hiding this comment.
should jsut remove this.
js/station.js
Outdated
| html += "<hr style='margin:0px;margin-top:5px'>"; | ||
| html += "</div>"; | ||
|
|
||
| html += "<div><b>Show Full Flight Path: <b><a href=\"javascript:showRecoveredMap('" + serial + "')\">" + serial + "</a></div>"; |
Member
Author
There was a problem hiding this comment.
missed this one for xss fix.
Member
There was a problem hiding this comment.
Fixed this one, and a few others nearby
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.