Make coordinates clickable everywhere #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for this! Could you please redirect this PR to the testing branch? |
Author
|
Sure, I'll do that in a few hours when I'm back at the computer. |
Author
|
I forgot to mention that I tested this on desktop and Android, but not with iPhone as I don't have a device to test with. |
argilo
force-pushed
the
link-coordinates
branch
from
6332ce2 to
7cfb4e7
Compare
Author
|
Rebased and re-tested. |
Member
|
Thanks! This is also cleans up the code a bit which is nice. It would be good to have this on sondehub-amateur-tracker too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a couple places, it's possible to click on coordinates to bring up an external mapping application:
Elsewhere, coordinates are displayed as plain text. It would be convenient to have coordinates displayed as a clickable link everywhere.
Here I extracted the common code for generating a link into a function (
format_coordinates), and used it to display coordinates in the following places: