Fix bug with car rotation #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I implemented it a few years back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new SVG system allows cars to rotate on the map. However, there is a bug that seems to happen with cars that do not have headings, where the car does not get rendered.
I tracked down the issue with this logic; it's that the setCourse call in line 1657 happens before the image is ready, so then the one that sets the course to 90 by default doesn't run, since
marker.rotatedbecomes true. Now, we will not update from gps heading unless the car is already rotated.Additionally, while running this through the debugger, I noticed a bunch of 404 errors originating from the file list in service_worker.js; I've gone ahead and cleaned up all the files that were listed there which no longer exist.
Not completely clear what service_worker.js is, but removing the names of the files which have subsequently been deleted seems to have removed the errors.