Skip to content

Conversation

@smwnwrght
Copy link

@smwnwrght smwnwrght commented May 7, 2024

Reinstates landing predictions for landed sondes.

I have tested this but would appreciate a review as I don't understand the other code in updatePredictions() - hence draft pull request!

@smwnwrght smwnwrght changed the title resolves #317 fixes #317 May 7, 2024
@TheSkorm
Copy link
Member

TheSkorm commented May 9, 2024

Thanks @smwnwrght. Can you please remove the white space changes from the PR so that it's only the relevant code changes?

@darksidelemm this will show the predictions all the time, even after landed - not sure if we came to a conclusion as to if that was a good idea or not?

@darksidelemm
Copy link
Member

I think this should be merged into the testing branch so we can check the behaviour out for a while.

@smwnwrght smwnwrght marked this pull request as ready for review May 9, 2024 11:01
@smwnwrght
Copy link
Author

@TheSkorm have reverted whitespace (and cleaned up my code!)

@smwnwrght
Copy link
Author

@darksidelemm Should I change this to the testing branch?

@darksidelemm
Copy link
Member

Yes, I think it should be possible for you to re-target this to the testing branch. I've just made sure testing is in line with the master branch.

@smwnwrght smwnwrght changed the base branch from master to testing May 9, 2024 14:00
@smwnwrght
Copy link
Author

@darksidelemm I have updated this to merge with the testing branch

@darksidelemm
Copy link
Member

OK, I'll merge this in. it will be visible at testing.v2.sondehub.org

@darksidelemm darksidelemm merged commit ffe062b into projecthorus:testing May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants