Fix Chase cars icons not showing on map#245
Merged
LukePrior merged 1 commit intoprojecthorus:testingfrom Mar 11, 2022
Merged
Conversation
HoshenKadosh
changed the title
Member
|
Oh awesome thanks for fixing this up, I will leave it in testing and if there aren't any problems I'll merge it into main shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #244 issue.
When there are multiple chase cars with the same color at site load, since the HTML img element is stored in icon_cache before the img loads, accessing it right away and making a canvas will not work since the img hasn’t loaded yet. So i added a listener for load.