Switch to circle marker for launch site icons#17
Merged
darksidelemm merged 1 commit intoprojecthorus:testingfrom Jun 27, 2021
LukePrior:master
Merged
Switch to circle marker for launch site icons#17darksidelemm merged 1 commit intoprojecthorus:testingfrom LukePrior:master
darksidelemm merged 1 commit intoprojecthorus:testingfrom
LukePrior:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When rendering ~700 markers Leaflet slowed considerably as each marker is an individual DOM.
I have switched to circleMarkers which render onto canvas so the performance is maintained.