Skip to content

Conversation

TheSkorm
Copy link
Member

This adds the ability to update prediction settings via Cognito login

Screen Recording 2022-05-11 at 10 31 26 am 2022-05-11 10_35_02

Copy link
Member

@LukePrior LukePrior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so I've got this running locally and have a few thoughts.

The balloon icon in the toolbar doesn't appear to be centered
image
I think the way icons are currently stored is as SVG in HabitatFont.svg but if it can be centered with CSS probably not worth the effort to add it to this.

When logging in the page is redirected to the login page, is it possible to instead have the login as a new popup tab so that the tracker doesn't need to reload on login.

Does the aws SDK need to be loaded in the head of the page and should we host it locally?

I tried login in with google but it failed however I assume this is simply an issue with doing it on localhost.

@TheSkorm
Copy link
Member Author

image

interesting, both safari and chrome center it for me?

regarding login - probably, but kind of annoying to implement easily. very few people will be using this feature so probably not worth the effort.

we could host it locally, but hotlinking should be fairly safe, and it might be users browser cache already. Just needs to load before mobile so I've moved it to the bottom.

Localhost should work, but the only supported urls for localdev are http://localhost:8000/

@LukePrior
Copy link
Member

Hmmm, the icon was weird on Chrome but if it works on your end it might just be an issue with some old cached CSS on my end.

Oh yeah if it requires lot's of changes the login thing should just be kept as is.

I was on http://localhost:8000/ but once again if it worked on your end all good.

@TheSkorm
Copy link
Member Author

I think it would be nice to get an SVG for that icon, the windows rendering is a bit meh. At the same time I don't really want to mess around with making an SVG or build the font file :/

image

@LukePrior
Copy link
Member

Oh I think it must be a different default font on Windows causing the different-looking balloon and styling error maybe. Yeah it would probably be good to get an SVG for consistency.

@TheSkorm TheSkorm force-pushed the feature/cognito_login branch from 3224310 to 5666b00 Compare May 11, 2022 08:36
@TheSkorm
Copy link
Member Author

Updated to include query
Screen Recording 2022-05-11 at 7 46 48 pm 2022-05-11 19_49_21

@TheSkorm TheSkorm merged commit a0b6e56 into main May 11, 2022
@TheSkorm TheSkorm deleted the feature/cognito_login branch July 20, 2025 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants