-
Notifications
You must be signed in to change notification settings - Fork 9
Prediction settings updater #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so I've got this running locally and have a few thoughts.
The balloon icon in the toolbar doesn't appear to be centered
I think the way icons are currently stored is as SVG in HabitatFont.svg but if it can be centered with CSS probably not worth the effort to add it to this.
When logging in the page is redirected to the login page, is it possible to instead have the login as a new popup tab so that the tracker doesn't need to reload on login.
Does the aws SDK need to be loaded in the head of the page and should we host it locally?
I tried login in with google but it failed however I assume this is simply an issue with doing it on localhost.
interesting, both safari and chrome center it for me?
regarding login - probably, but kind of annoying to implement easily. very few people will be using this feature so probably not worth the effort. we could host it locally, but hotlinking should be fairly safe, and it might be users browser cache already. Just needs to load before mobile so I've moved it to the bottom. Localhost should work, but the only supported urls for localdev are |
Hmmm, the icon was weird on Chrome but if it works on your end it might just be an issue with some old cached CSS on my end. Oh yeah if it requires lot's of changes the login thing should just be kept as is. I was on http://localhost:8000/ but once again if it worked on your end all good. |
Oh I think it must be a different default font on Windows causing the different-looking balloon and styling error maybe. Yeah it would probably be good to get an SVG for consistency. |
3224310
to
5666b00
Compare
This adds the ability to update prediction settings via Cognito login