Skip to content

Add support for TimezoneFinderL class from timezonefinder #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pnbruckner merged 2 commits into from
Mar 5, 2021
Merged

Add support for TimezoneFinderL class from timezonefinder #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdd3c8e
Add support for TimezoneFinderL class from timezonefinder
pnbruckner Mar 4, 2021
58894d5
Update README.md
pnbruckner Mar 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,13 @@ sudo apt install libatlas3-base

`timezonefinderL==2.0.1`
`timezonefinder`
`timezonefinder<6`
`timezonefinder==4.2.0`

- **tz_finder_class** (*Optional*): Specifies which class to use. Only applies when using `timezonefinder` package. Valid options are `TimezoneFinder` and `TimezoneFinderL`. The default is `TimezoneFinder`.

>Note: Starting with release 4.4.0 the `timezonefinder` package provides two classes to choose from: the original `TimezoneFinder` class, and a new class named `TimezoneFinderL`, which effectively replaces the functionality of the `timezonefinderL` package.

### `device_tracker` platform

- **entity_id**: Entity IDs of watched device tracker devices. Can be a single entity ID, a list of entity IDs, or a string containing multiple entity IDs separated by commas.
Expand Down Expand Up @@ -88,7 +94,8 @@ time_zone | The name of the time zone in which the device is located, or `unknow
### Example Full Config
```yaml
composite:
tz_finder: timezonefinderL==2.0.1
tz_finder: timezonefinder<6
tz_finder_class: TimezoneFinderL
device_tracker:
- platform: composite
name: me
Expand Down
21 changes: 18 additions & 3 deletions custom_components/composite/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,18 @@

CONF_TZ_FINDER = "tz_finder"
DEFAULT_TZ_FINDER = "timezonefinderL==4.0.2"
CONF_TZ_FINDER_CLASS = "tz_finder_class"
TZ_FINDER_CLASS_OPTS = ["TimezoneFinder", "TimezoneFinderL"]

CONFIG_SCHEMA = vol.Schema(
{
vol.Optional(DOMAIN, default=dict): vol.Schema(
{vol.Optional(CONF_TZ_FINDER, default=DEFAULT_TZ_FINDER): cv.string}
{
vol.Optional(CONF_TZ_FINDER, default=DEFAULT_TZ_FINDER): cv.string,
vol.Optional(
CONF_TZ_FINDER_CLASS, default=TZ_FINDER_CLASS_OPTS[0]
): vol.In(TZ_FINDER_CLASS_OPTS),
}
),
},
extra=vol.ALLOW_EXTRA,
Expand Down Expand Up @@ -48,8 +55,16 @@ def setup(hass, config):

if pkg.split("==")[0].strip().endswith("L"):
from timezonefinderL import TimezoneFinder
else:

tf = TimezoneFinder()
elif config[DOMAIN][CONF_TZ_FINDER_CLASS] == "TimezoneFinder":
from timezonefinder import TimezoneFinder
hass.data[DOMAIN] = TimezoneFinder()

tf = TimezoneFinder()
else:
from timezonefinder import TimezoneFinderL

tf = TimezoneFinderL()
hass.data[DOMAIN] = tf

return True