Clean up timezone selector behavior and add back to agenda RH panel#4
Merged
Merged
Conversation
* add "minimal" option to render tz select buttons only * move tz-display "onchange" events into timezone.js * update timezone.js to handle radio inputs in addition to select * render second timezone select widget on the agenda's floating RH panel
Previously, kept the magic word "local" to guess the local timezone, but this complicates keeping multiple sets of radios in sync. Instead, replace "local" with guessed timezone name at init time.
It will show until the end of the day, styled to indicate that it is not functional.
1 task
meadmaker
approved these changes
Apr 7, 2022
meadmaker
left a comment
meadmaker
left a comment
There was a problem hiding this comment.
My review comments are only first a question and second something that involve a code comment. Publish this whenever you feel ready.
| // Copyright The IETF Trust 2021, All Rights Reserved | ||
|
|
||
| // Copyright The IETF Trust 2021, All Rights Reserved | ||
| /* global moment */ |
Collaborator
Author
There was a problem hiding this comment.
It notifies eslint that 'moment' is a globally defined symbol
Collaborator
Author
There was a problem hiding this comment.
(though it certainly looks like something that we should all share on Earth Day)
|
|
||
| // Select timezone to use. Arg is name of a timezone or 'local' to guess local tz. | ||
| function use_timezone(newtz) { | ||
| // Guess local timezone if necessary |
There was a problem hiding this comment.
Seems like this comment should have been deleted along with the following lines that it described.
Collaborator
Author
There was a problem hiding this comment.
yep, thanks
Base automatically changed from
jennifer/tix3697
to
jennifer/current-agenda-session
April 7, 2022 13:19
jennifer-richards
changed the base branch from
jennifer/current-agenda-session
to
jennifer/agenda-tz-widget
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses ietf-tools#3737 by restoring the timezone selector and display to the RH navigation panel on the agenda page. It additionally cleans up the behavior of the existing selector a bit:
This javascript/html template is reused on the upcoming meetings page. The changes here address ietf-tools#3757 by removing the "Meeting" timezone option from that page.
This builds on changes made in #3, so I've temporarily targeted that branch. Once that is merged, I'll sort out the branching.