Spend hours in goals not displayed

[ggeorgg]

Function in question:

timetracker/lib/Controller/AjaxController.php

Line 1224 in 710cd33

public function getGoals(){

I am having trouble to get the goals displayed correctly. I have set up a 20 hours weekly goal, beginning on 1. September 2021

Unfortunately, no working interval is taken into consideration for this goal. (There are for sure a lot of working intervals in this time period.) I don't think it is related to some offset or UTC stuff.
I think it is related to this line in the code. I tried to debug it a bit and logged variables to a file. Here is what I get right before the if clause:
interval: 2021-09-27
$repItem->time: 1630476900

It appears like the if clause can never be true because of the data type mismatch, so that the code can never reach the break condition of this if clause. Therefore all hours are accounted to the "Past Debt in Hours" and "Remaining Hours" but the sum of "Hours spend" is always zero.

Does anybody else have this problem? If needed, I can also share more information about my setup.

Best regards
Georg

[kadrim]

yes, exactly my problem.

[kadrim]

working on a patch right now.

[kadrim]

will be ready as Pull-Request next Week, to generate more testing-data

[kadrim]

fix has been implemented, pull request #156 is available

[ggeorgg]

Thanks for this implemenation. I tried it and the spend hours are now displayed. This looks good now.
But if I compare the other columns to my Excel calculation, there is still an error in the calculation. (I guess a new issue should be opened. If yes, just let me know.)

Here is a screenshot of my current working hours

And here is a screenshot of my Excel calculation:

You can see

• "Hours spent current week" is correct now.
• "Past Debt in Hours": is wrong, I think because of the next point in the list. (Positive number, because we already worked more than expected)
• "Remaining Hours (current week?)": Value seems to be correct, but it should be negative in my opinion!
• "Total Remaining Hours": Looks like the values "Past Debt in Hours" and "Remaining Hours (current week?)" have been added. But due to the wrong "sign" just mentioned in the point before, this value is completly wrong.

[kadrim]

Can you upload your excel sheet, i can save some time that way as i don't have to create more testdata ;-)

Thanks in advance!

[ggeorgg]

Sure! Here it is:
WorkingTime.ods

[kadrim]

i think the problem is somewhere different. The calculation for the functions getStartOfWeek() and getStartOfMonth is wrong.
It does calculate correctly the date but always uses the time when the goal was created.

so if you have time-records at 08:00-09:00 and your goal was created at 10:00 those time-records will be excluded.

[kadrim]

i just updated the PR above, could you recheck with your database and worksheet?

[ggeorgg]

I just applied the latest change of your pull request, but it still does not correctly calculate the correct total remaining hours.

[kadrim]

to make it a little bit easier for me to track down the issue, could you please attach a database dump of your test-data?

so alle the table prefixed with oc_timetracker_?

[kadrim]

or can we narrow it down ith some simple entries?

[ggeorgg]

nextcloud.zip
WorkingTime-setTime0-0-0-0.ods
WorkingTime.ods

I tried to anonymize the data in the nextcloud.zip file. This is the database dump of the current database. I also updated the excel files so that they match the current database status. On Excel file contains the values with your second commit.

[kadrim]

thanks, i'll have a look