PriceTracker blocks bug 1451212

[mixedpuppy]

https://bugzilla.mozilla.org/show_bug.cgi?id=1451212

We have old code that we'd like to remove but (only) price tracker still uses the old call signature here:

price-tracker/src/experiment_apis/customizableUI/api.js

Lines 14 to 17 in 1e881c5

	onWidgetRemoved: new EventManager(
	context,
	'customizableUI.onWidgetRemoved',
	(fire) => {

It needs to be updated to something like:

new EventManager({
  context, 
  name: "customizableUI.onWidgetRemoved",
  register: (fire) => {
    const toolbarButton = {
      onWidgetRemoved(widgetId) {
        fire.async(widgetId);
      },
    };
    CustomizableUI.addListener(toolbarButton);
    return () => {
      CustomizableUI.removeListener(toolbarButton);
    };
  },
}).api(),

[biancadanforth]

Thanks @mixedpuppy for letting us know about this and whats more, gating landing the change until we update Price Tracker.

We are blocked on making changes to Price Tracker until our PM comes back from vacation next week. However, I have assessed the breakage that would occur in Price Tracker if we do nothing, and the consequences are minor: we lose the functionality from the customizableUI experimental API, but that is limited to the hide_toolbar_button telemetry event (#157 ) and a minor popup display issue for the Overflow menu on Linux (#256 ). Feel free to proceed with your patch at any time, as we can fix and deploy on our end very quickly next week if we need to.