Skip to content

Remove duplicate class PiwikTracker - #55

Merged
sgiehl merged 1 commit into
matomo-org:masterfrom
madman-81:master
Jan 2, 2020
Merged

Remove duplicate class PiwikTracker#55
sgiehl merged 1 commit into
matomo-org:masterfrom
madman-81:master

Conversation

@madman-81

Copy link
Copy Markdown
Contributor

Solves #54

The class PiwikTracker is declared in both PiwikTracker.php and MatomoTracker.php, but the latter is also included in PiwickTracker.php

@sgiehl
sgiehl merged commit 95eeeb2 into matomo-org:master Jan 2, 2020
@tsteur

tsteur commented Jan 2, 2020

Copy link
Copy Markdown
Member

@sgiehl can we do a if !class_exists() { class ... extends ...} in both classes ideally? Just to be safe in case for some reason MatomoTracker is included but still old class is used. Would just make it more stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants