Skip to content

Rebrand from Piwik to Matomo - #51

Merged
sgiehl merged 2 commits into
masterfrom
rebrand
Jan 1, 2020
Merged

Rebrand from Piwik to Matomo#51
sgiehl merged 2 commits into
masterfrom
rebrand

Conversation

@sgiehl

@sgiehl sgiehl commented Dec 9, 2019

Copy link
Copy Markdown
Member

Needs to be republished on packagist after merge with the new name, and the old one needs to be marked as Abandoned.

Comment thread MatomoTracker.php
@tsteur

tsteur commented Dec 19, 2019

Copy link
Copy Markdown
Member

Just a random thought... wondering if it makes sense to have PiwikTracker.php file as well including MatomoTracker.php and then in both PiwikTracker and MatomoTracker class we could have

if (!class_exists(PiwikTRacker)) { . class PiwikTracker extends MatomoTracker }? This way BC works no matter if Piwiktracker file was included or only Matomotracker? Just makes things bit easier even for us as we use PiwikTracker in various places and be great if we give people an easy way to update... otherwise everyone needs to check which file exists and while file should be loaded etc

In Matomo 5 we could then remove PiwikTracker completely (or leave it there if it doesn't cause us any issues)

@sgiehl

sgiehl commented Dec 30, 2019

Copy link
Copy Markdown
Member Author

@tsteur updated the PR

@tsteur

tsteur commented Dec 30, 2019

Copy link
Copy Markdown
Member

👍

@sgiehl
sgiehl merged commit 06a6b46 into master Jan 1, 2020
@sgiehl
sgiehl deleted the rebrand branch January 1, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants