Skip to content

Let users track ecommerce orders with the same SKU multiple times #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattab merged 1 commit into from
Jul 13, 2016
Merged

Let users track ecommerce orders with the same SKU multiple times #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions PiwikTracker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,7 @@ public function addEcommerceItem($sku, $name = '', $category = '', $price = 0.0,

$price = $this->forceDotAsSeparatorForDecimalPoint($price);

$this->ecommerceItems[$sku] = array($sku, $name, $category, $price, $quantity);
$this->ecommerceItems[] = array($sku, $name, $category, $price, $quantity);
}

/**
Expand Down Expand Up @@ -878,8 +878,10 @@ public function getUrlTrackEcommerceOrder(

/**
* Returns URL used to track Ecommerce orders
*
* Calling this function will reinitializes the property ecommerceItems to empty array
* so items will have to be added again via addEcommerceItem()
*
* @ignore
*/
protected function getUrlTrackEcommerce($grandTotal, $subTotal = 0.0, $tax = 0.0, $shipping = 0.0, $discount = 0.0)
Expand Down Expand Up @@ -911,12 +913,7 @@ protected function getUrlTrackEcommerce($grandTotal, $subTotal = 0.0, $tax = 0.0
$url .= '&ec_dt=' . $discount;
}
if (!empty($this->ecommerceItems)) {
// Removing the SKU index in the array before JSON encoding
$items = array();
foreach ($this->ecommerceItems as $item) {
$items[] = $item;
}
$url .= '&ec_items=' . urlencode(json_encode($items));
$url .= '&ec_items=' . urlencode(json_encode($this->ecommerceItems));
}
$this->ecommerceItems = array();

Expand Down Expand Up @@ -1906,4 +1903,4 @@ function Piwik_getUrlTrackGoal($idSite, $idGoal, $revenue = 0.0)
$tracker = new PiwikTracker($idSite);

return $tracker->getUrlTrackGoal($idGoal, $revenue);
}
}