Detect Google-GeminiNotebook as an AI bot - #153
Merged
Conversation
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Google renamed the
Google-NotebookLMUser-Agent token toGoogle-GeminiNotebook.The PHP tracker currently recognizes the former
Google-NotebookLMtoken but does not recognize the newGoogle-GeminiNotebooktoken. As a result,MatomoTracker::isUserAgentAIBot()returnsfalsefor requests using Google's current User-Agent, anddoTrackPageViewIfAIBot()does not track them.This change:
Google-GeminiNotebooktoAI_BOT_USER_AGENT_SUBSTRINGS;Google-NotebookLMfor backward compatibility during the transition;Google-NotebookLMtoken remains supported.Expected behavior:
No bot-name normalization is required in this repository because
isUserAgentAIBot()only returns a boolean. Normalization to the historicalGoogle-NotebookLMname is handled by Matomo core and Device Detector.Related work:
Google documentation:
https://developers.google.com/crawling/docs/crawlers-fetchers/google-user-triggered-fetchers#gemini-notebook
Checklist
Review
Validation
Unit tests were added for both the current and former User-Agent tokens.
The repository test suite has not yet been run locally.