Allow setting form factors client hint#136
Merged
Merged
Conversation
sgiehl
force-pushed
the
formfactors
branch
2 times, most recently
from
September 3, 2024 09:35
7507825 to
929a9b1
Compare
sgiehl
changed the title
michalkleiner
approved these changes
Oct 8, 2024
Co-authored-by: Michal Kleiner <mk@011.nz>
sgiehl
added a commit
that referenced
this pull request
Dec 20, 2025
* Allow settting form factors client hint * update changelog * Fix handling of some attributes * Apply review feedback Co-authored-by: Michal Kleiner <mk@011.nz> --------- Co-authored-by: Michal Kleiner <mk@011.nz>
sgiehl
added a commit
that referenced
this pull request
Dec 20, 2025
…ifferent API urls (#145) * Allow setting form factors client hint (#136) * Allow settting form factors client hint * update changelog * Fix handling of some attributes * Apply review feedback Co-authored-by: Michal Kleiner <mk@011.nz> --------- Co-authored-by: Michal Kleiner <mk@011.nz> * deprecate $URL * use old $URL if apiUrl is empty --------- Co-authored-by: Stefan Giehl <stefan@matomo.org> Co-authored-by: Michal Kleiner <mk@011.nz> Co-authored-by: Andrii Lutskevych <andrii.lutskevych@check24.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
refs matomo-org/matomo#22549
Review