Skip to content

Add tracking methods for the upcoming Crash Analytics premium feature - #110

Merged
sgiehl merged 2 commits into
masterfrom
crash-tracking-methods
Dec 7, 2022
Merged

Add tracking methods for the upcoming Crash Analytics premium feature#110
sgiehl merged 2 commits into
masterfrom
crash-tracking-methods

Conversation

@diosmosis

Copy link
Copy Markdown
Member

Description:

Adds:

  • doTrackCrash() - tracks a crash using provided information.
  • doTrackPhpThrowable() - tracks a crash, deducing information from the given \Throwable

Review

@diosmosis diosmosis added this to the Current sprint milestone Dec 5, 2022

@tsteur tsteur left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for this @diosmosis .

@sgiehl to get this into core do we need to trigger a new release and update it via composer?

@tsteur

tsteur commented Dec 6, 2022

Copy link
Copy Markdown
Member

We'll basically need it to get tests working in travis as the tests use this method.

@sgiehl

sgiehl commented Dec 6, 2022

Copy link
Copy Markdown
Member

@tsteur yes. a new release will be needed. will this be required in 4.x-dev branch or only 5.x-dev?

@tsteur

tsteur commented Dec 7, 2022

Copy link
Copy Markdown
Member

Ideally in 4.x-dev so the tests start passing sooner 👍

@sgiehl

sgiehl commented Dec 7, 2022

Copy link
Copy Markdown
Member

Ok. Will do that now.

@sgiehl
sgiehl merged commit 544148c into master Dec 7, 2022
@sgiehl
sgiehl deleted the crash-tracking-methods branch December 7, 2022 08:35
@innocraft-automation innocraft-automation removed this from the Current sprint milestone Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants