Fix failing model test

Author: tgaeta

Gemfile

@@ -20,6 +20,7 @@ gem "rexml", ">= 3.3.2"
 
 group :development, :test do
   gem "byebug", "~> 11.1", ">= 11.1.3"
+  gem "database_cleaner-active_record", "1.8.0.beta"
   gem "debug", "~> 1.9", ">= 1.9.2", platforms: %i[mri windows]
   gem "dotenv", "~> 3.1", ">= 3.1.2"
   gem "factory_bot_rails", "~> 6.4", ">= 6.4.3"

Gemfile.lock

@@ -104,6 +104,10 @@ GEM
     concurrent-ruby (1.2.3)
     connection_pool (2.4.1)
     crass (1.0.6)
+    database_cleaner (1.8.5)
+    database_cleaner-active_record (1.8.0.beta)
+      activerecord
+      database_cleaner (~> 1.8.0.beta)
     date (3.3.4)
     debug (1.9.2)
       irb (~> 1.10)
@@ -357,6 +361,7 @@ DEPENDENCIES
   bundler-audit (~> 0.9.1)
   byebug (~> 11.1, >= 11.1.3)
   colorize (~> 1.1)
+  database_cleaner-active_record (= 1.8.0.beta)
   debug (~> 1.9, >= 1.9.2)
   devise (~> 4.9)
   dotenv (~> 3.1, >= 3.1.2)

test/factories/job_applications_factory.rb

@@ -22,21 +22,5 @@
     trait :hired do
       status { "hired" }
     end
-
-    factory :job_application_phone do
-      method_of_contact { "phone" }
-    end
-
-    factory :job_application_unique do
-      company_name { "Unique Company" }
-    end
-
-    factory :job_application_jan_2 do
-      date_applied { Date.new(2023, 1, 2) }
-    end
-
-    factory :job_application_jan_1 do
-      date_applied { Date.new(2023, 1, 1) }
-    end
   end
 end

test/models/job_application_test.rb

@@ -6,7 +6,7 @@ def setup
   end
 
   test "valid job application" do
-    assert @job_application.valid?
+    assert @job_application.valid?, "Job application is not valid. Errors: #{@job_application.errors.full_messages}"
   end
 
   test "invalid without date_applied" do
@@ -77,39 +77,62 @@ def setup
   end
 
   test "by_method_of_contact scope" do
+    JobApplication.destroy_all
     create(:job_application, method_of_contact: "email")
     create(:job_application, :with_website)
 
+    puts "Total job applications: #{JobApplication.count}"
+    puts "Email job applications: #{JobApplication.by_method_of_contact("email").count}"
+    puts "Internet job applications: #{JobApplication.by_method_of_contact("internet_job_application").count}"
+
     assert_equal 1, JobApplication.by_method_of_contact("email").count
     assert_equal 1, JobApplication.by_method_of_contact("internet_job_application").count
   end
 
   test "by_position_type scope" do
+    JobApplication.destroy_all
     create(:job_application, position_type: "full_time")
     create(:job_application, position_type: "part_time")
 
+    puts "Total job applications: #{JobApplication.count}"
+    puts "Full-time job applications: #{JobApplication.by_position_type("full_time").count}"
+    puts "Part-time job applications: #{JobApplication.by_position_type("part_time").count}"
+
     assert_equal 1, JobApplication.by_position_type("full_time").count
     assert_equal 1, JobApplication.by_position_type("part_time").count
   end
 
   test "by_status scope" do
+    JobApplication.destroy_all
     create(:job_application, status: "interviewing")
-    create(:job_application, :hired)
+    create(:job_application, status: "hired")
+
+    puts "Total job applications: #{JobApplication.count}"
+    puts "Interviewing job applications: #{JobApplication.by_status("interviewing").count}"
+    puts "Hired job applications: #{JobApplication.by_status("hired").count}"
 
     assert_equal 1, JobApplication.by_status("interviewing").count
     assert_equal 1, JobApplication.by_status("hired").count
   end
 
   test "claimed_for_unemployment scope" do
-    create(:job_application, :claimed)
-    create(:job_application)
+    JobApplication.destroy_all
+    create(:job_application, claimed_for_unemployment: true)
+    create(:job_application, claimed_for_unemployment: false)
+
+    puts "Total job applications: #{JobApplication.count}"
+    puts "Claimed for unemployment: #{JobApplication.claimed_for_unemployment.count}"
 
     assert_equal 1, JobApplication.claimed_for_unemployment.count
   end
 
   test "not_claimed_for_unemployment scope" do
-    create(:job_application, :claimed)
-    create(:job_application)
+    JobApplication.destroy_all
+    create(:job_application, claimed_for_unemployment: true)
+    create(:job_application, claimed_for_unemployment: false)
+
+    puts "Total job applications: #{JobApplication.count}"
+    puts "Not claimed for unemployment: #{JobApplication.not_claimed_for_unemployment.count}"
 
     assert_equal 1, JobApplication.not_claimed_for_unemployment.count
   end

test/test_helper.rb

@@ -4,6 +4,7 @@
 require "minitest/reporters"
 require "factory_bot_rails"
 require "rails-controller-testing"
+require "database_cleaner/active_record"
 
 reporters = []
 
@@ -52,6 +53,16 @@ class TestCase
 
     # Add more helper methods to be used by all tests here...
     include FactoryBot::Syntax::Methods
+
+    DatabaseCleaner.strategy = :transaction
+
+    setup do
+      DatabaseCleaner.start
+    end
+
+    teardown do
+      DatabaseCleaner.clean
+    end
   end
 end