Add tests.

Author: tgaeta

Gemfile

@@ -24,6 +24,8 @@ group :development, :test do
   gem "dotenv", "~> 3.1", ">= 3.1.2"
   gem "factory_bot_rails", "~> 6.4", ">= 6.4.3"
   gem "faker", "~> 3.4"
+  gem "mocha", "~> 1.2", ">= 1.2.1"
+  gem "rails-controller-testing", "~> 0.0.3"
   gem "rubocop-rails-omakase", "~> 1.0", require: false, group: [:development]
   gem "minitest-reporters", "~> 1.6", ">= 1.6.1"
 end

Gemfile.lock

@@ -172,6 +172,7 @@ GEM
       builder
       minitest (>= 5.0)
       ruby-progressbar
+    mocha (1.16.1)
     msgpack (1.7.2)
     mutex_m (0.2.0)
     net-imap (0.4.13)
@@ -237,6 +238,8 @@ GEM
       activesupport (= 7.1.3.4)
       bundler (>= 1.15.0)
       railties (= 7.1.3.4)
+    rails-controller-testing (0.0.3)
+      rails (>= 4.2)
     rails-dom-testing (2.2.0)
       activesupport (>= 5.0.0)
       minitest
@@ -364,10 +367,12 @@ DEPENDENCIES
   jbuilder (~> 2.12)
   letter_opener (~> 1.10)
   minitest-reporters (~> 1.6, >= 1.6.1)
+  mocha (~> 1.2, >= 1.2.1)
   pg (~> 1.5, >= 1.5.6)
   phlex-rails (~> 1.2)
   puma (~> 6.4, >= 6.4.2)
   rails (~> 7.1, >= 7.1.3.4)
+  rails-controller-testing (~> 0.0.3)
   rexml (>= 3.3.2)
   rubocop (~> 1.63, >= 1.63.5)
   rubocop-factory_bot (~> 2.25, >= 2.25.1)

app/models/job_application.rb

@@ -4,7 +4,7 @@ class JobApplication < ApplicationRecord
   validates :date_applied, :company_name, :method_of_contact, :position_type, :position_title, presence: true
   validates :email_address, presence: true, if: -> { method_of_contact == "email" }
   validates :point_of_contact, presence: true, if: -> { ["email", "phone", "recruiter", "other"].include?(method_of_contact) }
-  validates :website_link, presence: true, if: -> { method_of_contact == "internet job application" }
+  validates :website_link, presence: true, if: -> { method_of_contact == "internet_job_application" }
   validates :website_link, url: {
     allow_blank: true,
     schemes: ["http", "https"],

test/controllers/job_applications_controller_test.rb

@@ -0,0 +1,84 @@
+require "test_helper"
+
+class JobApplicationsControllerTest < ActionDispatch::IntegrationTest
+  setup do
+    @job_application = create(:job_application)
+  end
+
+  test "should get index" do
+    get job_applications_url
+    assert_response :success
+  end
+
+  test "should get new" do
+    get new_job_application_url
+    assert_response :success
+  end
+
+  test "should create job_application" do
+    assert_difference("JobApplication.count") do
+      post job_applications_url, params: {job_application: attributes_for(:job_application)}
+    end
+
+    assert_redirected_to root_url
+  end
+
+  test "should get edit" do
+    get edit_job_application_url(@job_application)
+    assert_response :success
+  end
+
+  test "should update job_application" do
+    patch job_application_url(@job_application), params: {job_application: {company_name: "Updated Company"}}
+    assert_redirected_to root_url
+    @job_application.reload
+    assert_equal "Updated Company", @job_application.company_name
+  end
+
+  test "should destroy job_application" do
+    assert_difference("JobApplication.count", -1) do
+      delete job_application_url(@job_application)
+    end
+
+    assert_redirected_to root_url
+  end
+
+  test "should filter job_applications" do
+    create(:job_application_phone)
+    create(:job_application, :with_website)
+    create(:job_application, :hired)
+
+    get job_applications_url, params: {method_of_contact: "email"}
+    assert_response :success
+    assert_equal 1, @controller.view_assigns["job_applications"].count
+
+    get job_applications_url, params: {method_of_contact: "internet_job_application"}
+    assert_response :success
+    assert_equal 1, @controller.view_assigns["job_applications"].count
+
+    get job_applications_url, params: {status: "hired"}
+    assert_response :success
+    assert_equal 1, @controller.view_assigns["job_applications"].count
+  end
+
+  test "should search job_applications" do
+    create(:job_application_unique)
+
+    get job_applications_url, params: {search: "Unique"}
+    assert_response :success
+    assert_equal 1, @controller.view_assigns["job_applications"].count
+  end
+
+  test "should sort job_applications" do
+    create(:job_application_jan_2)
+    create(:job_application_jan_1)
+
+    get job_applications_url, params: {sort: "date_applied", direction: "asc"}
+    assert_response :success
+    assert_equal Date.new(2023, 1, 1), @controller.view_assigns["job_applications"].first.date_applied
+
+    get job_applications_url, params: {sort: "date_applied", direction: "desc"}
+    assert_response :success
+    assert_equal Date.new(2023, 1, 2), @controller.view_assigns["job_applications"].first.date_applied
+  end
+end

test/factories/job_applications_factory.rb

@@ -0,0 +1,42 @@
+FactoryBot.define do
+  factory :job_application do
+    date_applied { Date.new(2023, 1, 1) }
+    company_name { "Example Company" }
+    method_of_contact { "email" }
+    position_type { "full_time" }
+    position_title { "Software Engineer" }
+    claimed_for_unemployment { false }
+    status { "interviewing" }
+    email_address { "[email protected]" }
+    point_of_contact { "John Doe" }
+
+    trait :with_website do
+      method_of_contact { "internet_job_application" }
+      website_link { "https://example.com/jobs" }
+    end
+
+    trait :claimed do
+      claimed_for_unemployment { true }
+    end
+
+    trait :hired do
+      status { "hired" }
+    end
+
+    factory :job_application_phone do
+      method_of_contact { "phone" }
+    end
+
+    factory :job_application_unique do
+      company_name { "Unique Company" }
+    end
+
+    factory :job_application_jan_2 do
+      date_applied { Date.new(2023, 1, 2) }
+    end
+
+    factory :job_application_jan_1 do
+      date_applied { Date.new(2023, 1, 1) }
+    end
+  end
+end

test/models/job_application_test.rb

@@ -0,0 +1,116 @@
+require "test_helper"
+
+class JobApplicationTest < ActiveSupport::TestCase
+  def setup
+    @job_application = build(:job_application)
+  end
+
+  test "valid job application" do
+    assert @job_application.valid?
+  end
+
+  test "invalid without date_applied" do
+    @job_application.date_applied = nil
+    assert_not @job_application.valid?
+    assert_not_nil @job_application.errors[:date_applied]
+  end
+
+  test "invalid without company_name" do
+    @job_application.company_name = nil
+    assert_not @job_application.valid?
+    assert_not_nil @job_application.errors[:company_name]
+  end
+
+  test "invalid without method_of_contact" do
+    @job_application.method_of_contact = nil
+    assert_not @job_application.valid?
+    assert_not_nil @job_application.errors[:method_of_contact]
+  end
+
+  test "invalid without position_type" do
+    @job_application.position_type = nil
+    assert_not @job_application.valid?
+    assert_not_nil @job_application.errors[:position_type]
+  end
+
+  test "invalid without position_title" do
+    @job_application.position_title = nil
+    assert_not @job_application.valid?
+    assert_not_nil @job_application.errors[:position_title]
+  end
+
+  test "requires email_address when method_of_contact is email" do
+    @job_application.email_address = nil
+    assert_not @job_application.valid?
+    assert_not_nil @job_application.errors[:email_address]
+  end
+
+  test "requires website_link when method_of_contact is internet job application" do
+    @job_application = build(:job_application,
+      method_of_contact: "internet_job_application",
+      website_link: nil)
+
+    assert_not @job_application.valid?
+    assert_includes @job_application.errors.full_messages, "Website link can't be blank"
+  end
+
+  test "validates website_link format" do
+    @job_application = build(:job_application, :with_website)
+    @job_application.website_link = "invalid-url"
+    assert_not @job_application.valid?
+    assert_not_nil @job_application.errors[:website_link]
+  end
+
+  test "validates status inclusion" do
+    assert_raises(ArgumentError) do
+      build(:job_application, status: "invalid_status")
+    end
+  end
+
+  test "search scope" do
+    create(:job_application, company_name: "Unique Company")
+    create(:job_application, position_title: "Unique Position")
+
+    assert_equal 1, JobApplication.search("Unique Company").count
+    assert_equal 1, JobApplication.search("Unique Position").count
+    assert_equal 2, JobApplication.search("Unique").count
+  end
+
+  test "by_method_of_contact scope" do
+    create(:job_application, method_of_contact: "email")
+    create(:job_application, :with_website)
+
+    assert_equal 1, JobApplication.by_method_of_contact("email").count
+    assert_equal 1, JobApplication.by_method_of_contact("internet_job_application").count
+  end
+
+  test "by_position_type scope" do
+    create(:job_application, position_type: "full_time")
+    create(:job_application, position_type: "part_time")
+
+    assert_equal 1, JobApplication.by_position_type("full_time").count
+    assert_equal 1, JobApplication.by_position_type("part_time").count
+  end
+
+  test "by_status scope" do
+    create(:job_application, status: "interviewing")
+    create(:job_application, :hired)
+
+    assert_equal 1, JobApplication.by_status("interviewing").count
+    assert_equal 1, JobApplication.by_status("hired").count
+  end
+
+  test "claimed_for_unemployment scope" do
+    create(:job_application, :claimed)
+    create(:job_application)
+
+    assert_equal 1, JobApplication.claimed_for_unemployment.count
+  end
+
+  test "not_claimed_for_unemployment scope" do
+    create(:job_application, :claimed)
+    create(:job_application)
+
+    assert_equal 1, JobApplication.not_claimed_for_unemployment.count
+  end
+end

test/test_helper.rb

@@ -2,6 +2,8 @@
 require_relative "../config/environment"
 require "rails/test_help"
 require "minitest/reporters"
+require "factory_bot_rails"
+require "rails-controller-testing"
 
 reporters = []
 
@@ -17,6 +19,29 @@
 end
 Minitest::Reporters.use! reporters
 
+class ActionDispatch::IntegrationTest
+  setup do
+    # Mock Vite helpers
+    ActionView::Base.class_eval do
+      def vite_javascript_tag(*args)
+        ""
+      end
+
+      def vite_client_tag
+        ""
+      end
+
+      def vite_stylesheet_tag(*args)
+        ""
+      end
+
+      def vite_asset_path(*args)
+        ""
+      end
+    end
+  end
+end
+
 module ActiveSupport
   class TestCase
     # Run tests in parallel with specified workers
@@ -26,6 +51,7 @@ class TestCase
     fixtures :all
 
     # Add more helper methods to be used by all tests here...
+    include FactoryBot::Syntax::Methods
   end
 end