Skip to content

Improve performance by caching Filament components and warn if APP_KEY is missing #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thespad merged 8 commits into from
Jun 7, 2024
Merged

Improve performance by caching Filament components and warn if APP_KEY is missing #19

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
255cece
cache filament components
alexjustesen Jun 7, 2024
2fb2a4d
warn and no longer generate an app key
alexjustesen Jun 7, 2024
4f3e90e
added app key to a required param and updated change log
alexjustesen Jun 7, 2024
052deae
better key wording
alexjustesen Jun 7, 2024
9df787b
dont copy production env file, no longer exists
alexjustesen Jun 7, 2024
e22556d
Sleep if no app_key set. Add dummy app_key to CI
thespad Jun 7, 2024
769db0a
Add new vars to readme
thespad Jun 7, 2024
b5cd776
Consistency tweaks
thespad Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
warn and no longer generate an app key
  • Loading branch information
@alexjustesen
alexjustesen committed Jun 7, 2024
commit 2fb2a4dd0cc890d2ebc2d11b49786b7da5969e22
5 changes: 2 additions & 3 deletions root/etc/s6-overlay/s6-rc.d/init-speedtest-tracker-config/run
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,8 @@ done
# Check for app key
if [[ -z ${APP_KEY} ]]; then
if ! grep -E "APP_KEY=[0-9A-Za-z:+\/=]{1,}" /app/www/.env > /dev/null; then
export APP_KEY=$(s6-setuidgid abc php /app/www/artisan key:generate --show)
echo "An application key was generated at start up, as no environment variable was set."
echo "To set an application key that persists, read the docs: https://docs.speedtest-tracker.dev/"
echo "An application key is missing!"
echo "Go to https://speedtest-tracker.dev/ generate an application key."
fi
fi

Expand Down