This repository was archived by the owner on May 22, 2025. It is now read-only.
Add support for XLSX report output #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Wow! Awesome job, this is really great. Thank you so much for this contribution! <3 |
kriskbx
reviewed
Sep 8, 2018
src/output/xlsx.js
Outdated
| XLSX.utils.book_append_sheet(workbook, this.xlsxRecords, 'Records'); | ||
| } | ||
|
|
||
| XLSX.writeFile(workbook, fileName + extName); |
Owner
There was a problem hiding this comment.
fileName = path.basename() already contains the extension, so you get a double extension when saving files. Can you remove extName completely?
Collaborator
Author
|
Fixed. Thanks for pointing that out! |
Owner
|
I just released version 1.7.26 which includes your addition. Thank you very much! |
Collaborator
Author
|
Awesome! thanks for the quick handling! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for XLSX output for reports