Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@sils
Copy link
Contributor

@sils sils commented Jul 13, 2018

no idea if this is a good change but it does fix #60 for me, feedback/insight from @kriskbx would be appreciated

@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.368% when pulling aea0ab4 on viper-development:sils/null into 35b8f91 on kriskbx:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.368% when pulling aea0ab4 on viper-development:sils/null into 35b8f91 on kriskbx:master.

@coveralls
Copy link

coveralls commented Jul 13, 2018

Coverage Status

Coverage remained the same at 67.368% when pulling aea0ab4 on viper-development:sils/null into 35b8f91 on kriskbx:master.

@naveenkumarsangi
Copy link

@sils, this is actually a good and valid change. From the documentation for Time.toHumanReadable, null is an invalid parameter. Reference:

/**
* get human readable
* @param input
* @param hoursPerDay
* @param format
* @returns {string}
*/
static toHumanReadable(input, hoursPerDay = 8, format = time.defaultTimeFormat) {

@kriskbx
Copy link
Owner

kriskbx commented Aug 1, 2018

You're totally right. This was unintended, actually the null should have gone in the constructor of the Time object. Thank you for your contribution and for fixing it and sorry for the long delay.

@kriskbx kriskbx merged commit adb310c into kriskbx:master Aug 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: could not process issues.

4 participants