This repository was archived by the owner on May 22, 2025. It is now read-only.
Merged
Conversation
2 similar comments
|
@sils, this is actually a good and valid change. From the documentation for gitlab-time-tracker/src/models/time.js Lines 104 to 111 in 35b8f91 |
Owner
|
You're totally right. This was unintended, actually the null should have gone in the constructor of the Time object. Thank you for your contribution and for fixing it and sorry for the long delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no idea if this is a good change but it does fix #60 for me, feedback/insight from @kriskbx would be appreciated