This repository was archived by the owner on May 22, 2025. It is now read-only.
Fix rate limit of 600 requests per minutes on Gitlab.com #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simple fix, maximum of 10 requests per seconds = maximum of 600 requests per minutes. It does slow down a bit the report but it prevent a fatal error. It's possible to design a more sophisticated fix but it will be more complex with more states to manage. It would be more prone to bugs. I favor simplicity over maximum speed.
cgdobre
suggested changes
Jun 3, 2020
Collaborator
cgdobre
left a comment
cgdobre
left a comment
There was a problem hiding this comment.
Thank you for this contribution. It will be a great improvement!
src/models/base.js
Outdated
Comment on lines
5
to
7
| const throttledQueue = require('throttled-queue'); | ||
|
|
||
| const throttle = throttledQueue(10, 1000); |
Collaborator
There was a problem hiding this comment.
Let's have a way to configure requests per second, as it is done now for parallel. Of course, this means also that:
-
the declaration of throttle needs to be moved inside the base object.
-
the new throttle parameter needs to be added in the configuration
Suggested change
| const throttledQueue = require('throttled-queue'); | |
| const throttle = throttledQueue(10, 1000); | |
| const throttledQueue = require('throttled-queue'); | |
| [...] | |
| let throttle = throttledQueue(this._throttle, 1000); | |
| [...] |
src/models/base.js
Outdated
Comment on lines
42
to
56
| throttle(() => { | ||
| request.post(`${this.url}${path}`, { | ||
| json: true, | ||
| body: data, | ||
| insecure: this._insecure, | ||
| proxy: this._proxy, | ||
| resolveWithFullResponse: true, | ||
| headers: { | ||
| 'PRIVATE-TOKEN': this.token | ||
| } | ||
| }).then(response => { | ||
| if (this.config.get('_createDump')) this.setDump(response, key); | ||
| resolve(response); | ||
| }).catch(e => reject(e)); | ||
| }) |
Collaborator
There was a problem hiding this comment.
Let's move throttle() on line up to minimize the diff
Suggested change
| throttle(() => { | |
| request.post(`${this.url}${path}`, { | |
| json: true, | |
| body: data, | |
| insecure: this._insecure, | |
| proxy: this._proxy, | |
| resolveWithFullResponse: true, | |
| headers: { | |
| 'PRIVATE-TOKEN': this.token | |
| } | |
| }).then(response => { | |
| if (this.config.get('_createDump')) this.setDump(response, key); | |
| resolve(response); | |
| }).catch(e => reject(e)); | |
| }) | |
| return new Promise((resolve, reject) => throttle(() => { | |
| request.post(`${this.url}${path}`, { | |
| json: true, | |
| body: data, | |
| insecure: this._insecure, | |
| proxy: this._proxy, | |
| resolveWithFullResponse: true, | |
| headers: { | |
| 'PRIVATE-TOKEN': this.token | |
| } | |
| }).then(response => { | |
| if (this.config.get('_createDump')) this.setDump(response, key); | |
| resolve(response); | |
| }).catch(e => reject(e)); | |
| })); |
src/models/base.js
Outdated
Comment on lines
74
to
88
| return new Promise((resolve, reject) => { | ||
| request(`${this.url}${path}`, { | ||
| json: true, | ||
| insecure: this._insecure, | ||
| proxy: this._proxy, | ||
| resolveWithFullResponse: true, | ||
| headers: { | ||
| 'PRIVATE-TOKEN': this.token | ||
| } | ||
| }).then(response => { | ||
| if (this.config.get('_createDump')) this.setDump(response, key); | ||
| resolve(response); | ||
| }).catch(e => reject(e)); | ||
| throttle(() => { | ||
| request(`${this.url}${path}`, { | ||
| json: true, | ||
| insecure: this._insecure, | ||
| proxy: this._proxy, | ||
| resolveWithFullResponse: true, | ||
| headers: { | ||
| 'PRIVATE-TOKEN': this.token | ||
| } | ||
| }).then(response => { | ||
| if (this.config.get('_createDump')) this.setDump(response, key); | ||
| resolve(response); | ||
| }).catch(e => reject(e)); | ||
| }) |
Collaborator
There was a problem hiding this comment.
same suggestion as above. Move throttle one line up and un-indent the request lines to minimize the diff.
Collaborator
|
PS: also update and include the yarn.lock file because the CI job fails without it |
Collaborator
|
PS2: goes without saying, if you need any help with the changes, just ask. |
This was
linked to
issues
Jun 7, 2020
Closed
- whitepace magic to minimize diff - update yarn.lock file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple fix, maximum of 10 requests per seconds = maximum of 600 requests per minutes. It does slow down a bit the report but it prevent a fatal error. It's possible to design a more sophisticated fix but it will be more complex with more states to manage. It would be more prone to bugs. I favor simplicity over maximum speed.