This repository was archived by the owner on May 22, 2025. It is now read-only.
Docs fix for usage as lib example#10
Merged
kriskbx merged 2 commits intokriskbx:masterfrom Aug 10, 2017
Merged
Conversation
Owner
|
Thanks for your pull request! I really appreciate it. You're right: there are errors in the docs. To be honest: I never used async/await before. I just learned about Promises when I ported |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to integrate the module into my own project as lib and found some issues regarding outdated paths and function names in the example code.
Also the example code wasn't working using the promises approach therefore I upgraded the example to async/await (not sure if that's wanted)