Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@leschekfm
Copy link
Contributor

I tried to integrate the module into my own project as lib and found some issues regarding outdated paths and function names in the example code.

Also the example code wasn't working using the promises approach therefore I upgraded the example to async/await (not sure if that's wanted)

@kriskbx
Copy link
Owner

kriskbx commented Aug 10, 2017

Thanks for your pull request! I really appreciate it. You're right: there are errors in the docs.

To be honest: I never used async/await before. I just learned about Promises when I ported gtt from PHP to nodejs. (I'm actually a PHP dev) I think I understood the concept behind it, but I definetely lack some experience working with it. I will look into it within the next week and maybe even refactor the core code to async/await as it looks way cleaner then the Promise-chaining I did before.

@kriskbx kriskbx merged commit 8279e6b into kriskbx:master Aug 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants