Allow to specify the hours per day on the command line

[elboletaire]

We use gtt to extract information about our workers' time spent, and every worker has a different time per day schedule.

I've seen that I can specify oursPerDay in the yaml file, but not via command line (I've already checked gtt-report.js).

An --hours_per_day param would be much appreciated.

I've also noticed that setting timeFormat defines the time format for all the times shown, if we could show the overall time spent in hours only in the TIME STATS part would work as a workaround for us instead of having to specify --hours_per_day. I guess there's no way to do that currently, right?

Thanks in advance :)

[kriskbx]

Sure, I can add an --hours_per_dayoption. I haven't done that because working hours per day for what I know are usually 8 - maybe 6 in some Scandinavian countries. This is something you define once and usually never change it.

I would love to implement a way of specifying the time format for different parts of the report. Let's discuss this first: adding multiple options like statsTimeFormat, issueTimeFormat, ... is kinda bugging me. I did that with the columns: issueColumns, mergeRequestColumns and I don't like it. I would rather do something like this in the config:

timeFormat:
    stats: "[hours_overall]h"
    issues: ...

If you use a string instead of an array in your config, it uses the given format everywhere. Additionally I would implement some bulky command line options: --time_format_stats, --time_format_issues, ... If you use only --time_format it uses the given format everywhere again.

I would also love to refactor the whole columns thing to work the same way. What do you think about it? Do you have any better or more "clean & easy" way of configuring this?

[elboletaire]

Yeah working with arrays with various levels makes sense if you're working with yaml 😃

[kriskbx]

I just released version 1.6.9 including the --hours_per_day option. Still working on the config though.

[elboletaire]

Perfect @kriskbx! Really much appreciated 😃

[elboletaire]

Should I close the issue? Or will you track in this same issue the timeFormat stuff?

[kriskbx]

Keep it open. :)

[kriskbx]

I just pushed the first draft of the new time format configuration to the master branch (didn't released it yet, though). Can you do me favor by checking it out and giving me your feedback?

Do you need those command line options --time_format_stats, --time_format_issues, etc.? I'm thinking about dropping those as well as --issue_columns, --merge_request_columns and make the whole time format and column-thing configuration only. I want to keep the command line API as simple as possible, but highly configurable via the yaml files. What do you think about this?

[elboletaire]

Of course @kriskbx, when I arrive home today (I'm at work now) I'll try to.

Just to clarify, finally the format is the stated above?

timeFormat:
    stats: "[hours_overall]h"
    issues: ...

I won't use the inline arguments for the formats, so don't do it for me. I also think there's no need for this commands to be available as an arg, but maybe other users think different.

In my case I use always the same format for all the reports, and if there's a case where I would use different formats I'd use the config files instead.

[kriskbx]

Like this:

# Time format for different parts of the report
# Instead of specifying one global time format you can specify one for every
# part of the report and the log command
timeFormat:
  log: "[%sign][%hours_overall]"
  stats: "[%sign][%days_overall]"
  issues: "[%sign][%hours_overall]"
  merge_requests: "[%sign][%hours_overall]"
  records: "[%sign][%days>d ][%hours>h ][%minutes>m ][%seconds>s]"

[elboletaire]

Hey @kriskbx sorry for the delay. I marked the notification as read and I forgot about it...

I just copied the lines stated above and the app crashes with a could not process issues error:

I'm using a local configuration file created with node src/gtt.js config --local, I don't know if that could affect or if I'm missing something.

[kriskbx]

I'm sorry: there was a bug I introduced with another feature I'm working on. Can you pull the master branch and try again?

[elboletaire]

Apparently works as expected.

Is there any way to round numbers? Just asking :_D

[kriskbx]

Sure, I could introduce something like [%hours_overall_rounded>2] where 2 is the number of decimals to keep. (Wording is wip)