Skip to content

fix: TTL-836 customer duplicated error message #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2023
Merged

fix: TTL-836 customer duplicated error message #999

merged 2 commits into from
Jul 25, 2023

Conversation

mmaquina
Copy link
Contributor

@mmaquina mmaquina commented Jul 24, 2023 •
edited by jira bot
Loading

Description

Fix empty message when trying to save a new customer whose name already exist

Files changed

  • src/app/modules/customer-management/store/customer-management.effects.spec.ts
  • src/app/modules/customer-management/store/customer-management.effects.ts

Task board

Acceptance criteria

Message when trying to save a new customer whose name already exist is 'Duplicated'

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

[infrastructure/][stage] Terraform Plan 📖 failure

Show Plan ```

terraform

</details>
*Pusher: @mmaquina, Action: `pull_request`*

@github-actions
Copy link

[infrastructure/][prod] Terraform Plan 📖 failure

Show Plan ```

terraform

</details>
*Pusher: @mmaquina, Action: `pull_request`*

@github-actions
Copy link

[infrastructure/][stage] Terraform Plan 📖 failure

Show Plan ```

terraform

</details>
*Pusher: @mmaquina, Action: `pull_request`*

@github-actions
Copy link

[infrastructure/][prod] Terraform Plan 📖 failure

Show Plan ```

terraform

</details>
*Pusher: @mmaquina, Action: `pull_request`*

Santiago220991
Santiago220991 approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@Santiago220991 Santiago220991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@mmaquina mmaquina merged commit c14da22 into master Jul 25, 2023
@mmaquina mmaquina deleted the TTL-836-fix-error-message-when-trying-to-create-a-customer-whose-name-already-exists branch July 25, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Santiago220991 Santiago220991 Santiago220991 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmaquina @Santiago220991