TTL 886 display time zone reports #988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaquina
reviewed
May 23, 2023
| <td class="col x-sm-col text-center">{{ dateTimeOffset.parseDateTimeOffset(entry.start_date, entry.timezone_offset) }}</td> | ||
| <td class="col x-sm-col text-center">{{ dateTimeOffset.parseDateTimeOffset(entry.end_date, entry.timezone_offset) }}</td> | ||
| <td class="col sm-col text-center"> | ||
| UTC{{(entry.timezone_offset < 0)? "+": ""}}{{- entry.timezone_offset/60}} |
Contributor
There was a problem hiding this comment.
Suggested change
| UTC{{(entry.timezone_offset < 0)? "+": ""}}{{- entry.timezone_offset/60}} | |
| UTC{{ (entry.timezone_offset < 0) ? "+" : "" }}{{ - entry.timezone_offset / 60 }} |
[infrastructure/][stage] Terraform Plan 📖
|
[infrastructure/][prod] Terraform Plan 📖
|
mmaquina
reviewed
May 23, 2023
Contributor
mmaquina
left a comment
mmaquina
left a comment
There was a problem hiding this comment.
just one lint thing on the html file
|
Kudos, SonarCloud Quality Gate passed!
|
[infrastructure/][stage] Terraform Plan 📖
|
[infrastructure/][prod] Terraform Plan 📖
|
mmaquina
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new column named time zone was added to show the local time where the time entry was created.
Files changed
src/app/modules/reports/components/time-entries-table/time-entries-table.component.html
src/app/modules/reports/components/time-entries-table/time-entries-table.component.spec.ts
src/app/modules/shared/models/entry.model.ts
Task board