Skip to content

fix: TTL-727-bug-fix-error-400-on-project-update-function #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolsss merged 2 commits into from
Dec 12, 2022
Merged

fix: TTL-727-bug-fix-error-400-on-project-update-function #960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ac9fec
refactor: TTL-727-bug-as-a-software-developer-i-want-to-fix-error-400…
Dec 5, 2022
371c358
refactor: inactivated project message
Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/modules/customer-management/components/projects/components/store/project.effects.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { INFO_SAVED_SUCCESSFULLY, INFO_DELETE_SUCCESSFULLY } from '../../../../../shared/messages';
import { INFO_SAVED_SUCCESSFULLY, PROJECT_DEACTIVATED_SUCCESSFULLY } from '../../../../../shared/messages';
import { Injectable } from '@angular/core';
import { of, Observable } from 'rxjs';
import { catchError, map, mergeMap } from 'rxjs/operators';
Expand Down Expand Up @@ -108,7 +108,7 @@ export class ProjectEffects {
mergeMap((projectId) =>
this.projectService.deleteProject(projectId).pipe(
map(() => {
this.toastrService.success(INFO_DELETE_SUCCESSFULLY);
this.toastrService.success(PROJECT_DEACTIVATED_SUCCESSFULLY);
return new actions.DeleteProjectSuccess(projectId);
}),
catchError((error) => {
Expand Down
1 change: 1 addition & 0 deletions src/app/modules/shared/messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
export const INFO_SAVED_SUCCESSFULLY = 'The data has been saved successfully';
export const INFO_DELETE_SUCCESSFULLY = 'The data has been deleted successfully';
export const UNEXPECTED_ERROR = 'An unexpected error happened, please try again later';
export const PROJECT_DEACTIVATED_SUCCESSFULLY = 'The project has been inactivated successfully';