Skip to content

TTA-196-duration-column-formatting-ui #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 28, 2022
Merged

TTA-196-duration-column-formatting-ui #941

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2a535f7
refactor: TTA-196 duration as float on reports
mmaquina Oct 20, 2022
b26c0a6
changed pipe function
mmaquina Oct 21, 2022
d3061d7
refactor: TTA-196 display hours as float
mmaquina Oct 21, 2022
0b5c0b8
refactor: TTA-196 fix imports and lint errors
mmaquina Oct 21, 2022
d260b32
refactor: TTA-196 number of fixed digits as constant with name
mmaquina Oct 21, 2022
d433bda
fix: TTA-196 variable was ill defined
mmaquina Oct 24, 2022
ab06c75
refactor: TTA-196 Merge branch 'master' into TTA-196-duration-column…
mmaquina Oct 25, 2022
dd3a06c
Merge branch 'master' into TTA-196-duration-column-formatting-ui
mmaquina Oct 27, 2022
4f42ff4
refactor: TTA-196 2 digits for fixed point duration of time entries i…
mmaquina Oct 27, 2022
2952053
fix: TTA-196 fixed tests for 2 fixed point digits. TODO: use that con…
mmaquina Oct 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: TTA-196 number of fixed digits as constant with name
  • Loading branch information
@mmaquina
mmaquina committed Oct 21, 2022
commit d260b32c5fb7ee47549d6721aedef216d0441e9a
4 changes: 3 additions & 1 deletion src/app/modules/shared/pipes/substract-date-return-float/substract-date-return-float.pipe.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import { Pipe, PipeTransform } from '@angular/core';
import * as moment from 'moment';

let FIXED_POINT_DIGITS 1;
@Pipe({
name: 'substractDateDisplayAsFloat'
})
Expand All @@ -14,7 +16,7 @@ export class SubstractDatePipeDisplayAsFloat implements PipeTransform {
const startDate = moment(substractDate);
const endDate = moment(fromDate);
const duration = this.getTimeDifference(startDate, endDate);
return duration.asHours().toFixed(1).toString();
return duration.asHours().toFixed(FIXED_POINT_DIGITS).toString();
}

getTimeDifference(substractDate: moment.Moment, fromDate: moment.Moment): moment.Duration {
Expand Down