Skip to content

Conversation

@mmaquina
Copy link
Contributor

@mmaquina mmaquina commented Oct 4, 2022

No description provided.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #937 (4813ccb) into master (df9071c) will decrease coverage by 0.74%.
The diff coverage is 90.69%.

@@            Coverage Diff             @@
##           master     #937      +/-   ##
==========================================
- Coverage   97.48%   96.74%   -0.75%     
==========================================
  Files         107      112       +5     
  Lines        2430     2645     +215     
  Branches      203      230      +27     
==========================================
+ Hits         2369     2559     +190     
- Misses         23       38      +15     
- Partials       38       48      +10     
Impacted Files Coverage Δ
...nents/projects/components/store/project.effects.ts 100.00% <ø> (ø)
...ared/components/input-date/input-date.component.ts 93.33% <ø> (ø)
src/app/modules/time-clock/store/entry.reducer.ts 97.72% <ø> (ø)
...rc/app/modules/time-clock/store/entry.selectors.ts 55.55% <0.00%> (-6.95%) ⬇️
...ts/projects/components/services/project.service.ts 88.23% <33.33%> (-5.89%) ⬇️
...les/shared/components/sidebar/sidebar.component.ts 96.29% <50.00%> (-3.71%) ⬇️
src/app/modules/login/login.component.ts 68.75% <63.15%> (-27.09%) ⬇️
...p/modules/time-clock/pages/time-clock.component.ts 96.55% <66.66%> (+0.12%) ⬆️
...c/app/modules/time-clock/services/entry.service.ts 96.55% <75.00%> (+0.12%) ⬆️
src/app/modules/user/services/user-info.service.ts 87.50% <84.61%> (-12.50%) ⬇️
... and 29 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

[infrastructure/][stage] Terraform Plan 📖 success

Show Plan ```

terraform
module.ui.azurerm_app_service.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-service-stage-ui]
module.ui.azurerm_dns_cname_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Network/dnszones/timetrackerapp.stage.ioet.com/CNAME/ui]
module.ui.azurerm_app_service_custom_hostname_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-service-stage-ui/hostNameBindings/ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_dns_txt_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Network/dnszones/timetrackerapp.stage.ioet.com/TXT/asuid.ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_app_service_managed_certificate.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/certificates/ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_app_service_certificate_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-service-stage-ui/hostNameBindings/ui.timetrackerapp.stage.ioet.com|/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/certificates/ui.timetrackerapp.stage.ioet.com]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place

Terraform will perform the following actions:

module.ui.azurerm_app_service.this will be updated in-place

~ resource "azurerm_app_service" "this" {
id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-service-stage-ui"
name = "time-tracker-service-stage-ui"
tags = {}
# (17 unchanged attributes hidden)

  ~ site_config {
      ~ linux_fx_version                     = (sensitive)
        # (29 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

    # (3 unchanged blocks hidden)
}

Plan: 0 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

</details>
*Pusher: @mmaquina, Action: `pull_request`*

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

[infrastructure/][prod] Terraform Plan 📖 success

Show Plan ```

terraform
module.ui.azurerm_app_service.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/sites/time-tracker-service-prod-ui]
module.ui.azurerm_app_service_custom_hostname_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/sites/time-tracker-service-prod-ui/hostNameBindings/ui.timetrackerapp.ioet.com]
module.ui.azurerm_dns_cname_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Network/dnszones/timetrackerapp.ioet.com/CNAME/ui]
module.ui.azurerm_dns_txt_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Network/dnszones/timetrackerapp.ioet.com/TXT/asuid.ui.timetrackerapp.ioet.com]
module.ui.azurerm_app_service_managed_certificate.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/certificates/ui.timetrackerapp.ioet.com]
module.ui.azurerm_app_service_certificate_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/sites/time-tracker-service-prod-ui/hostNameBindings/ui.timetrackerapp.ioet.com|/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/certificates/ui.timetrackerapp.ioet.com]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place

Terraform will perform the following actions:

module.ui.azurerm_app_service.this will be updated in-place

~ resource "azurerm_app_service" "this" {
id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/sites/time-tracker-service-prod-ui"
name = "time-tracker-service-prod-ui"
tags = {}
# (17 unchanged attributes hidden)

  ~ site_config {
      ~ linux_fx_version                     = (sensitive)
        # (29 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

    # (3 unchanged blocks hidden)
}

Plan: 0 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

</details>
*Pusher: @mmaquina, Action: `pull_request`*

@mmaquina mmaquina merged commit 676a249 into master Oct 5, 2022
@mmaquina mmaquina deleted the TTA-181-change-husky-help-message branch October 5, 2022 16:55
andresacg30 pushed a commit that referenced this pull request Oct 6, 2022
nicolsss pushed a commit that referenced this pull request Oct 17, 2022
* feat: TTA-193 add preload page

* fix: TTA-181 change husky hint when commit message is wrong (#937)

Co-authored-by: mmaquina <[email protected]>

* chore(release): 1.75.21 [skip ci]nn

* feat: TTA-193 add service and interceptor for spinner loading

* feat: TTA-193 add spinner overlay and style it

* test: TTA-193 make test

* update package-lock.json version

* test: add test for interceptor and service

* test: TTA-193 increase code coverage

* test: TTA-193 increase code coverage

* fix: spinner test

* fix: spinner test

* fix: load spinner when route is recent

Co-authored-by: mmaquina <[email protected]>
Co-authored-by: mmaquina <[email protected]>
Co-authored-by: semantic-release-bot <[email protected]>
Co-authored-by: Andres Cabrera <andres@MSI>
Co-authored-by: Nicole Garcia <nicolsss>
andresacg30 pushed a commit that referenced this pull request Oct 24, 2022
andresacg30 added a commit that referenced this pull request Oct 24, 2022
* feat: TTA-193 add preload page

* fix: TTA-181 change husky hint when commit message is wrong (#937)

Co-authored-by: mmaquina <[email protected]>

* chore(release): 1.75.21 [skip ci]nn

* feat: TTA-193 add service and interceptor for spinner loading

* feat: TTA-193 add spinner overlay and style it

* test: TTA-193 make test

* update package-lock.json version

* test: add test for interceptor and service

* test: TTA-193 increase code coverage

* test: TTA-193 increase code coverage

* fix: spinner test

* fix: spinner test

* fix: load spinner when route is recent

Co-authored-by: mmaquina <[email protected]>
Co-authored-by: mmaquina <[email protected]>
Co-authored-by: semantic-release-bot <[email protected]>
Co-authored-by: Andres Cabrera <andres@MSI>
Co-authored-by: Nicole Garcia <nicolsss>
mmaquina added a commit that referenced this pull request Oct 24, 2022
* refactor: TTA-180 change  Client URL for Auth URL

* TTA-180: fixing endpoints to send credentials

* refactor: TTA-115 refactor backend URL for dev

* refactor: TTA-115 pass the environment auth variable link to the a tag

* fix: TTA-115 fix error Type 'string' is not assignable to type 'void in login.component

* feat: TTA-180 creating logout

* fix: TTA-180 fixing tests

* fix: TTA-180 fixing environment variables

* fix: TTA-180 fixing environment variables

* fix: TTA-180 fixing environment variables

* fix: TTA-180 fixing environment variables

* fix: TTA-180 fixing environment variables

* fix: TTA-180 fixing environment variables

* feat: TTA-180 updating README.md

* fix: TTA-180 removing unused variables

* fix: TTA-180 increasing test coveragew

* fix: TTA-180 increasing test coveragew

* fix: TTA-180 CR fixes

* config: TTA-180 added secrets for stage and prod

* fix: TTA-181 change husky hint when commit message is wrong (#937)

Co-authored-by: mmaquina <[email protected]>

* chore(release): 1.75.21 [skip ci]nn

* fix: TTA 183 get summary returns 404 at begginning of the month (#938)

Co-authored-by: Nicole Garcia <nicolsss>

* chore(release): 1.75.22 [skip ci]nn

* Update README.md

* Update README.md

* fix: Tta 193 add loading page to new ip check load time (#939)

* feat: TTA-193 add preload page

* fix: TTA-181 change husky hint when commit message is wrong (#937)

Co-authored-by: mmaquina <[email protected]>

* chore(release): 1.75.21 [skip ci]nn

* feat: TTA-193 add service and interceptor for spinner loading

* feat: TTA-193 add spinner overlay and style it

* test: TTA-193 make test

* update package-lock.json version

* test: add test for interceptor and service

* test: TTA-193 increase code coverage

* test: TTA-193 increase code coverage

* fix: spinner test

* fix: spinner test

* fix: load spinner when route is recent

Co-authored-by: mmaquina <[email protected]>
Co-authored-by: mmaquina <[email protected]>
Co-authored-by: semantic-release-bot <[email protected]>
Co-authored-by: Andres Cabrera <andres@MSI>
Co-authored-by: Nicole Garcia <nicolsss>

* chore(release): 1.75.24 [skip ci]nn

* adding Andres Cabrera ppk to STAGE secrets

* adding Andres Cabrera ppk to PROD secrets

* Added secrets for auth app on stage and prod

* Revert "Tta 180 integrate time tracker with auth app (#940)" (#942)

This reverts commit 0d4c2ff.

* revert adding stage and prod envs

* config: TTA-180 added secrets for stage and prod

* Tta 180 integrate time tracker with auth app (#940)

* refactor: TTA-180 change  Client URL for Auth URL

* TTA-180: fixing endpoints to send credentials

* refactor: TTA-115 refactor backend URL for dev

* refactor: TTA-115 pass the environment auth variable link to the a tag

* fix: TTA-115 fix error Type 'string' is not assignable to type 'void in login.component

* feat: TTA-180 creating logout

* fix: TTA-180 fixing tests

* fix: TTA-180 fixing environment variables

* fix: TTA-180 fixing environment variables

* fix: TTA-180 fixing environment variables

* fix: TTA-180 fixing environment variables

* fix: TTA-180 fixing environment variables

* fix: TTA-180 fixing environment variables

* feat: TTA-180 updating README.md

* fix: TTA-180 removing unused variables

* fix: TTA-180 increasing test coveragew

* fix: TTA-180 increasing test coveragew

* fix: TTA-180 CR fixes

Co-authored-by: Abigail Cabascango <sacabascango1espe.edu.ec>

* Added secrets for auth app on stage and prod

Co-authored-by: Abigail Cabascango <sacabascango1espe.edu.ec>
Co-authored-by: = <[email protected]>
Co-authored-by: Rodrigo Lins <[email protected]>
Co-authored-by: mmaquina <[email protected]>
Co-authored-by: mmaquina <[email protected]>
Co-authored-by: semantic-release-bot <[email protected]>
Co-authored-by: nicolsss <[email protected]>
Co-authored-by: Andres Cabrera <andres@MSI>
Co-authored-by: Rodolfo IOET <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants