Skip to content

Conversation

abigailscl
Copy link
Contributor

Description

  • Refactor

Files changed

  • src/app/modules/customer-management/components/projects/components/services/project.service.ts
  • src/app/modules/effects/services-management.service.spec.ts
  • src/app/modules/effects/services-management.service.ts

Aceptance Criteria

  • Delete repetitive code using good practices.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 16 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #934 (74773e7) into master (df9071c) will decrease coverage by 0.78%.
The diff coverage is 90.69%.

❗ Current head 74773e7 differs from pull request most recent head 140f68b. Consider uploading reports for the commit 140f68b to get more accurate results

@@            Coverage Diff             @@
##           master     #934      +/-   ##
==========================================
- Coverage   97.48%   96.70%   -0.79%     
==========================================
  Files         107      112       +5     
  Lines        2430     2644     +214     
  Branches      203      230      +27     
==========================================
+ Hits         2369     2557     +188     
- Misses         23       39      +16     
- Partials       38       48      +10     
Impacted Files Coverage Δ
...nents/projects/components/store/project.effects.ts 100.00% <ø> (ø)
...ared/components/input-date/input-date.component.ts 93.33% <ø> (ø)
src/app/modules/time-clock/store/entry.reducer.ts 97.72% <ø> (ø)
...rc/app/modules/time-clock/store/entry.selectors.ts 55.55% <0.00%> (-6.95%) ⬇️
...ts/projects/components/services/project.service.ts 87.50% <33.33%> (-6.62%) ⬇️
...les/shared/components/sidebar/sidebar.component.ts 96.29% <50.00%> (-3.71%) ⬇️
src/app/modules/login/login.component.ts 68.75% <63.15%> (-27.09%) ⬇️
...p/modules/time-clock/pages/time-clock.component.ts 96.55% <66.66%> (+0.12%) ⬆️
...c/app/modules/time-clock/services/entry.service.ts 96.55% <75.00%> (+0.12%) ⬆️
src/app/modules/user/services/user-info.service.ts 87.50% <84.61%> (-12.50%) ⬇️
... and 30 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

[infrastructure/][stage] Terraform Plan 📖 success

Show Plan ```

terraform
module.ui.azurerm_app_service.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-service-stage-ui]
module.ui.azurerm_dns_txt_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Network/dnszones/timetrackerapp.stage.ioet.com/TXT/asuid.ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_dns_cname_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Network/dnszones/timetrackerapp.stage.ioet.com/CNAME/ui]
module.ui.azurerm_app_service_custom_hostname_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-service-stage-ui/hostNameBindings/ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_app_service_managed_certificate.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/certificates/ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_app_service_certificate_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-service-stage-ui/hostNameBindings/ui.timetrackerapp.stage.ioet.com|/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/certificates/ui.timetrackerapp.stage.ioet.com]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place

Terraform will perform the following actions:

module.ui.azurerm_app_service.this will be updated in-place

~ resource "azurerm_app_service" "this" {
id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-service-stage-ui"
name = "time-tracker-service-stage-ui"
tags = {}
# (17 unchanged attributes hidden)

  ~ site_config {
      ~ linux_fx_version                     = (sensitive)
        # (29 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

    # (3 unchanged blocks hidden)
}

Plan: 0 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

</details>
*Pusher: @abigailscl, Action: `pull_request`*

@github-actions
Copy link

[infrastructure/][prod] Terraform Plan 📖 success

Show Plan ```

terraform
Acquiring state lock. This may take a few moments...
module.ui.azurerm_app_service.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/sites/time-tracker-service-prod-ui]
module.ui.azurerm_dns_txt_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Network/dnszones/timetrackerapp.ioet.com/TXT/asuid.ui.timetrackerapp.ioet.com]
module.ui.azurerm_dns_cname_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Network/dnszones/timetrackerapp.ioet.com/CNAME/ui]
module.ui.azurerm_app_service_custom_hostname_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/sites/time-tracker-service-prod-ui/hostNameBindings/ui.timetrackerapp.ioet.com]
module.ui.azurerm_app_service_managed_certificate.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/certificates/ui.timetrackerapp.ioet.com]
module.ui.azurerm_app_service_certificate_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/sites/time-tracker-service-prod-ui/hostNameBindings/ui.timetrackerapp.ioet.com|/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/certificates/ui.timetrackerapp.ioet.com]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place

Terraform will perform the following actions:

module.ui.azurerm_app_service.this will be updated in-place

~ resource "azurerm_app_service" "this" {
id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/sites/time-tracker-service-prod-ui"
name = "time-tracker-service-prod-ui"
tags = {}
# (17 unchanged attributes hidden)

  ~ site_config {
      ~ linux_fx_version                     = (sensitive)
        # (29 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

    # (3 unchanged blocks hidden)
}

Plan: 0 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

</details>
*Pusher: @abigailscl, Action: `pull_request`*

@abigailscl abigailscl closed this Sep 30, 2022
@abigailscl abigailscl deleted the TTA-164-refactor-apply-design-patterns-in-services branch September 30, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant