feat: TTA-83 Improve Admins Validation in Frontend #908

reihtw · 2022-07-27T13:30:33Z

No description provided.

github-actions · 2022-07-27T13:38:36Z

[infrastructure/][stage] Terraform Plan 📖 `success`

Show Plan

```

terraform
module.ui.azurerm_app_service_plan.plan[0]: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/serverfarms/time-tracker-ui-stage]
module.ui.azurerm_app_service.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage]
module.ui.azurerm_app_service_custom_hostname_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage/hostNameBindings/ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_dns_txt_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Network/dnszones/timetrackerapp.stage.ioet.com/TXT/asuid.ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_dns_cname_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Network/dnszones/timetrackerapp.stage.ioet.com/CNAME/ui]
module.ui.azurerm_app_service_managed_certificate.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/certificates/ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_app_service_certificate_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage/hostNameBindings/ui.timetrackerapp.stage.ioet.com|/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/certificates/ui.timetrackerapp.stage.ioet.com]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place

Terraform will perform the following actions:

module.ui.azurerm_app_service.this will be updated in-place

~ resource "azurerm_app_service" "this" {
id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage"
name = "time-tracker-ui-stage"
tags = {}
# (17 unchanged attributes hidden)

  ~ site_config {
      ~ linux_fx_version                     = (sensitive)
        # (29 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

    # (3 unchanged blocks hidden)
}

Plan: 0 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

</details>
*Pusher: @reihtw, Action: `pull_request`*

github-actions · 2022-07-27T13:38:37Z

[infrastructure/][prod] Terraform Plan 📖 `success`

Show Plan

```

terraform

</details>
*Pusher: @reihtw, Action: `pull_request`*

codecov · 2022-07-27T13:42:48Z

Codecov Report

Merging #908 (a5f6b0d) into master (df9071c) will decrease coverage by 0.39%.
The diff coverage is 93.28%.

❗ Current head a5f6b0d differs from pull request most recent head beb2798. Consider uploading reports for the commit beb2798 to get more accurate results

@@            Coverage Diff             @@
##           master     #908      +/-   ##
==========================================
- Coverage   97.48%   97.09%   -0.40%     
==========================================
  Files         107      113       +6     
  Lines        2430     2613     +183     
  Branches      203      218      +15     
==========================================
+ Hits         2369     2537     +168     
- Misses         23       38      +15     
  Partials       38       38

Impacted Files	Coverage Δ
...nents/projects/components/store/project.effects.ts	`100.00% <ø> (ø)`
...ared/components/input-date/input-date.component.ts	`93.33% <ø> (ø)`
src/app/modules/time-clock/store/entry.reducer.ts	`97.72% <ø> (ø)`
...rc/app/modules/time-clock/store/entry.selectors.ts	`55.55% <0.00%> (-6.95%)`	⬇️
...app/modules/login/services/azure.ad.b2c.service.ts	`68.57% <42.85%> (-18.93%)`	⬇️
src/app/modules/login/services/login.service.ts	`86.48% <72.22%> (-13.52%)`	⬇️
...p/modules/time-clock/pages/time-clock.component.ts	`96.66% <80.00%> (+0.23%)`	⬆️
src/app/modules/user/services/user-info.service.ts	`90.90% <87.50%> (-9.10%)`	⬇️
src/app/modules/login/login.component.ts	`89.28% <92.85%> (-6.55%)`	⬇️
src/app/guards/login-guard/login.guard.ts	`100.00% <100.00%> (ø)`
... and 31 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

github-actions · 2022-07-27T13:46:18Z

[infrastructure/][stage] Terraform Plan 📖 `success`

Show Plan

```

terraform
module.ui.azurerm_app_service_plan.plan[0]: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/serverfarms/time-tracker-ui-stage]
module.ui.azurerm_app_service.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage]
module.ui.azurerm_dns_cname_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Network/dnszones/timetrackerapp.stage.ioet.com/CNAME/ui]
module.ui.azurerm_app_service_custom_hostname_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage/hostNameBindings/ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_dns_txt_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Network/dnszones/timetrackerapp.stage.ioet.com/TXT/asuid.ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_app_service_managed_certificate.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/certificates/ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_app_service_certificate_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage/hostNameBindings/ui.timetrackerapp.stage.ioet.com|/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/certificates/ui.timetrackerapp.stage.ioet.com]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place

Terraform will perform the following actions:

module.ui.azurerm_app_service.this will be updated in-place

~ resource "azurerm_app_service" "this" {
id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage"
name = "time-tracker-ui-stage"
tags = {}
# (17 unchanged attributes hidden)

  ~ site_config {
      ~ linux_fx_version                     = (sensitive)
        # (29 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

    # (3 unchanged blocks hidden)
}

Plan: 0 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

</details>
*Pusher: @reihtw, Action: `pull_request`*

github-actions · 2022-07-27T13:46:19Z

[infrastructure/][prod] Terraform Plan 📖 `success`

Show Plan

```

terraform

</details>
*Pusher: @reihtw, Action: `pull_request`*

* Tta 50 error when editing an entry (#907) * fix: TTA-50 Error when editing an entry * fix: TTA-50 Error when editing an entry * Tta 94 refactor endpoints to make it work on tt stage and tt prod (#903) * Innecesary env files deleted * New changes to env files * Add 1 git-crypt collaborator New collaborators: F295BDD1 Marco Aguirre <[email protected]> * Add 1 git-crypt collaborator New collaborators: 1CC2872D Rodolfo Diaz <[email protected]> * Add 2 git-crypt collaborators New collaborators: 1CC2872D Rodolfo Diaz <[email protected]> F295BDD1 Marco Aguirre <[email protected]> * New keys and env variables added * env files added & modified * Make run now uses .dev.env * Pipeline modified * is the .env needed? * using encrypted .stage.env * load secrets * adding env variables * scopes cannot be empty * use env * using env var * using env file * adding mask * using docker buildkit * only on tags * using buildkit directly * using dash source * docker buildkit * missing folders added * nginx fix * fixing secrets * problem with double qoutes * fixing quotes in .stage.env * fixing secrets * loading to env * quotes fixed * replacing \r * fixing trailing \n * one line expose * fixing endpoint url * removing unnecessary jobs * update creds * adding with space at the end of the file * primer commit * cambios en users list components * Se ajusta la variable isDevelopmentOrProd * revision tests * reportsUrl como variable global Co-authored-by: Marco Aguirre <[email protected]> Co-authored-by: Marco Aguirre <[email protected]> Co-authored-by: Rodolfo IOET <[email protected]> Co-authored-by: jisazac <[email protected]> Co-authored-by: Juan Isaza <[email protected]> * Set copy of package.json and npm install before copying all other project files (#906) * Set copy of package.json and npm install before copying all other project files * Fix error on COPY on Dockerfiles Co-authored-by: Gustavo Lozada <[email protected]> * feat: TTA-113 Set a new logo for TT - version 2 (#909) Co-authored-by: Jimmy Jaramillo <[email protected]> * chore(release): 1.74.0 [skip ci]nn Co-authored-by: wilc0519 <[email protected]> Co-authored-by: Juan Esteban Isaza Cadavid <[email protected]> Co-authored-by: Marco Aguirre <[email protected]> Co-authored-by: Marco Aguirre <[email protected]> Co-authored-by: Rodolfo IOET <[email protected]> Co-authored-by: jisazac <[email protected]> Co-authored-by: Juan Isaza <[email protected]> Co-authored-by: GuLozada99 <[email protected]> Co-authored-by: Gustavo Lozada <[email protected]> Co-authored-by: Jimmy Jaramillo <[email protected]> Co-authored-by: Jimmy Jaramillo <[email protected]> Co-authored-by: semantic-release-bot <[email protected]>

* Tta 50 error when editing an entry (#907) * fix: TTA-50 Error when editing an entry * fix: TTA-50 Error when editing an entry * Tta 94 refactor endpoints to make it work on tt stage and tt prod (#903) * Innecesary env files deleted * New changes to env files * Add 1 git-crypt collaborator New collaborators: F295BDD1 Marco Aguirre <[email protected]> * Add 1 git-crypt collaborator New collaborators: 1CC2872D Rodolfo Diaz <[email protected]> * Add 2 git-crypt collaborators New collaborators: 1CC2872D Rodolfo Diaz <[email protected]> F295BDD1 Marco Aguirre <[email protected]> * New keys and env variables added * env files added & modified * Make run now uses .dev.env * Pipeline modified * is the .env needed? * using encrypted .stage.env * load secrets * adding env variables * scopes cannot be empty * use env * using env var * using env file * adding mask * using docker buildkit * only on tags * using buildkit directly * using dash source * docker buildkit * missing folders added * nginx fix * fixing secrets * problem with double qoutes * fixing quotes in .stage.env * fixing secrets * loading to env * quotes fixed * replacing \r * fixing trailing \n * one line expose * fixing endpoint url * removing unnecessary jobs * update creds * adding with space at the end of the file * primer commit * cambios en users list components * Se ajusta la variable isDevelopmentOrProd * revision tests * reportsUrl como variable global Co-authored-by: Marco Aguirre <[email protected]> Co-authored-by: Marco Aguirre <[email protected]> Co-authored-by: Rodolfo IOET <[email protected]> Co-authored-by: jisazac <[email protected]> Co-authored-by: Juan Isaza <[email protected]> * Set copy of package.json and npm install before copying all other project files (#906) * Set copy of package.json and npm install before copying all other project files * Fix error on COPY on Dockerfiles Co-authored-by: Gustavo Lozada <[email protected]> * feat: TTA-113 Set a new logo for TT - version 2 (#909) Co-authored-by: Jimmy Jaramillo <[email protected]> * chore(release): 1.74.0 [skip ci]nn Co-authored-by: wilc0519 <[email protected]> Co-authored-by: Juan Esteban Isaza Cadavid <[email protected]> Co-authored-by: Marco Aguirre <[email protected]> Co-authored-by: Marco Aguirre <[email protected]> Co-authored-by: jisazac <[email protected]> Co-authored-by: Juan Isaza <[email protected]> Co-authored-by: GuLozada99 <[email protected]> Co-authored-by: Gustavo Lozada <[email protected]> Co-authored-by: Jimmy Jaramillo <[email protected]> Co-authored-by: Jimmy Jaramillo <[email protected]> Co-authored-by: semantic-release-bot <[email protected]>

sonarqubecloud · 2022-08-09T15:28:48Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

github-actions · 2022-08-09T15:41:32Z

[infrastructure/][stage] Terraform Plan 📖 `failure`

Show Plan

```

terraform

</details>
*Pusher: @reihtw, Action: `pull_request`*

github-actions · 2022-08-09T15:41:33Z

[infrastructure/][prod] Terraform Plan 📖 `success`

Show Plan

```

terraform

</details>
*Pusher: @reihtw, Action: `pull_request`*

github-actions · 2022-08-09T18:38:55Z

[infrastructure/][stage] Terraform Plan 📖 `success`

Show Plan

```

terraform
module.ui.azurerm_app_service_plan.plan[0]: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/serverfarms/time-tracker-ui-stage]
module.ui.azurerm_app_service.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage]
module.ui.azurerm_app_service_custom_hostname_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage/hostNameBindings/ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_dns_cname_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Network/dnszones/timetrackerapp.stage.ioet.com/CNAME/ui]
module.ui.azurerm_dns_txt_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Network/dnszones/timetrackerapp.stage.ioet.com/TXT/asuid.ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_app_service_managed_certificate.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/certificates/ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_app_service_certificate_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage/hostNameBindings/ui.timetrackerapp.stage.ioet.com|/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/certificates/ui.timetrackerapp.stage.ioet.com]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place

Terraform will perform the following actions:

module.ui.azurerm_app_service.this will be updated in-place

~ resource "azurerm_app_service" "this" {
id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage"
name = "time-tracker-ui-stage"
tags = {}
# (17 unchanged attributes hidden)

  ~ site_config {
      ~ linux_fx_version                     = (sensitive)
        # (29 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

    # (3 unchanged blocks hidden)
}

Plan: 0 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

</details>
*Pusher: @reihtw, Action: `pull_request`*

github-actions · 2022-08-09T18:38:56Z

[infrastructure/][prod] Terraform Plan 📖 `success`

Show Plan

```

terraform

</details>
*Pusher: @reihtw, Action: `pull_request`*

This reverts commit 607fc91.

jimmyjaramillo and others added 7 commits June 30, 2022 17:13

fix: TTA-83 improve admin validation

55d9da6

fix: TTA-83 improve admin validation

4250cbf

feat TTA-83: frontend admin validation

d0911f4

fix TTA-83: fixing conflicts

c695593

fix TTA-83: Returning to login functions to subscribe

3f691c4

fix TTA-83: Fixing login component tests

c56d61c

fix TTA-83: Sonarcloud fix

1ccac53

reihtw requested review from andresacg and rodolfoIOET July 27, 2022 15:40

Rodrigo Lins and others added 6 commits August 5, 2022 10:25

fix TTA-83: Adding legacy login

24d945e

fix TTA-83: fixing tests

b461870

Updating TTA-83 branch

beb2798

reihtw merged commit 607fc91 into master Aug 12, 2022

reihtw deleted the TTA-83-improve-admins-validation-in-frontend branch August 12, 2022 15:53

reihtw changed the title ~~Tta 83 improve admins validation in frontend~~ feat: TTA-83 Improve Admins Validation in Frontend Aug 12, 2022

reihtw pushed a commit that referenced this pull request Aug 12, 2022

Revert "Tta 83 improve admins validation in frontend (#908)"

31e1112

This reverts commit 607fc91.

reihtw mentioned this pull request Aug 12, 2022

Revert "feat: TTA-83 Improve Admins Validation in Frontend" #917

Merged

reihtw pushed a commit that referenced this pull request Aug 12, 2022

Revert "Tta 83 improve admins validation in frontend (#908)" (#917)

6716334

This reverts commit 607fc91.

reihtw restored the TTA-83-improve-admins-validation-in-frontend branch August 12, 2022 20:08

reihtw deleted the TTA-83-improve-admins-validation-in-frontend branch August 12, 2022 20:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: TTA-83 Improve Admins Validation in Frontend #908

feat: TTA-83 Improve Admins Validation in Frontend #908

Uh oh!

reihtw commented Jul 27, 2022

Uh oh!

github-actions bot commented Jul 27, 2022

module.ui.azurerm_app_service.this will be updated in-place

Uh oh!

github-actions bot commented Jul 27, 2022

Uh oh!

codecov bot commented Jul 27, 2022 •

edited

Loading

Uh oh!

github-actions bot commented Jul 27, 2022

module.ui.azurerm_app_service.this will be updated in-place

Uh oh!

github-actions bot commented Jul 27, 2022

Uh oh!

sonarqubecloud bot commented Aug 9, 2022

Uh oh!

github-actions bot commented Aug 9, 2022

Uh oh!

github-actions bot commented Aug 9, 2022

Uh oh!

github-actions bot commented Aug 9, 2022

module.ui.azurerm_app_service.this will be updated in-place

Uh oh!

github-actions bot commented Aug 9, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat: TTA-83 Improve Admins Validation in Frontend #908

feat: TTA-83 Improve Admins Validation in Frontend #908

Uh oh!

Conversation

reihtw commented Jul 27, 2022

Uh oh!

github-actions bot commented Jul 27, 2022

[infrastructure/][stage] Terraform Plan 📖 success

module.ui.azurerm_app_service.this will be updated in-place

Uh oh!

github-actions bot commented Jul 27, 2022

[infrastructure/][prod] Terraform Plan 📖 success

Uh oh!

codecov bot commented Jul 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jul 27, 2022

[infrastructure/][stage] Terraform Plan 📖 success

module.ui.azurerm_app_service.this will be updated in-place

Uh oh!

github-actions bot commented Jul 27, 2022

[infrastructure/][prod] Terraform Plan 📖 success

Uh oh!

sonarqubecloud bot commented Aug 9, 2022

Uh oh!

github-actions bot commented Aug 9, 2022

[infrastructure/][stage] Terraform Plan 📖 failure

Uh oh!

github-actions bot commented Aug 9, 2022

[infrastructure/][prod] Terraform Plan 📖 success

Uh oh!

github-actions bot commented Aug 9, 2022

[infrastructure/][stage] Terraform Plan 📖 success

module.ui.azurerm_app_service.this will be updated in-place

Uh oh!

github-actions bot commented Aug 9, 2022

[infrastructure/][prod] Terraform Plan 📖 success

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[infrastructure/][stage] Terraform Plan 📖 `success`

[infrastructure/][prod] Terraform Plan 📖 `success`

codecov bot commented Jul 27, 2022 •

edited

Loading

[infrastructure/][stage] Terraform Plan 📖 `success`

[infrastructure/][prod] Terraform Plan 📖 `success`

[infrastructure/][stage] Terraform Plan 📖 `failure`

[infrastructure/][prod] Terraform Plan 📖 `success`

[infrastructure/][stage] Terraform Plan 📖 `success`

[infrastructure/][prod] Terraform Plan 📖 `success`