Skip to content

fix: TTA-29 Selecting multiple time entries and show total of hours o… #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 18, 2022
Merged

fix: TTA-29 Selecting multiple time entries and show total of hours o… #896

merged 5 commits into from
Jul 18, 2022

Conversation

wilc0519
Copy link
Contributor

@wilc0519 wilc0519 commented Jul 4, 2022

…f selected entries

@codecov
Copy link

codecov bot commented Jul 4, 2022 •
edited
Loading

Codecov Report

Merging #896 (869ea63) into master (df9071c) will increase coverage by 0.16%.
The diff coverage is 99.40%.

❗ Current head 869ea63 differs from pull request most recent head 68cdc69. Consider uploading reports for the commit 68cdc69 to get more accurate results

@@            Coverage Diff             @@
##           master     #896      +/-   ##
==========================================
+ Coverage   97.48%   97.65%   +0.16%     
==========================================
  Files         107      112       +5     
  Lines        2430     2562     +132     
  Branches      203      213      +10     
==========================================
+ Hits         2369     2502     +133     
+ Misses         23       21       -2     
- Partials       38       39       +1
Impacted Files Coverage Δ
...nents/projects/components/store/project.effects.ts 100.00% <ø> (ø)
...ared/components/input-date/input-date.component.ts 93.33% <ø> (ø)
src/app/modules/time-clock/store/entry.reducer.ts 97.72% <ø> (ø)
...rc/app/modules/time-clock/store/entry.selectors.ts 55.55% <0.00%> (-6.95%) ⬇️
src/app/guards/login-guard/login.guard.ts 100.00% <100.00%> (ø)
...anagement/pages/activities-management.component.ts 100.00% <100.00%> (ø)
...-management/store/activity-management.selectors.ts 90.00% <100.00%> (+1.11%) ⬆️
...ts/projects/components/services/project.service.ts 94.11% <100.00%> (ø)
...nents/projects/components/store/project.actions.ts 100.00% <100.00%> (ø)
...nents/projects/components/store/project.reducer.ts 97.22% <100.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfb2ae1...68cdc69. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jul 4, 2022

[infrastructure/][stage] Terraform Plan 📖 success

Show Plan ```

terraform
module.ui.azurerm_app_service_plan.plan[0]: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/serverfarms/time-tracker-ui-stage]
module.ui.azurerm_app_service.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage]
module.ui.azurerm_app_service_custom_hostname_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage/hostNameBindings/ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_dns_txt_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Network/dnszones/timetrackerapp.stage.ioet.com/TXT/asuid.ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_dns_cname_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Network/dnszones/timetrackerapp.stage.ioet.com/CNAME/ui]
module.ui.azurerm_app_service_managed_certificate.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/certificates/ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_app_service_certificate_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage/hostNameBindings/ui.timetrackerapp.stage.ioet.com|/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/certificates/ui.timetrackerapp.stage.ioet.com]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place

Terraform will perform the following actions:

module.ui.azurerm_app_service.this will be updated in-place

~ resource "azurerm_app_service" "this" {
id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage"
name = "time-tracker-ui-stage"
tags = {}
# (17 unchanged attributes hidden)

  ~ site_config {
      ~ linux_fx_version                     = (sensitive)
        # (29 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

    # (3 unchanged blocks hidden)
}

Plan: 0 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

</details>
*Pusher: @wilc0519, Action: `pull_request`*

@github-actions
Copy link

github-actions bot commented Jul 4, 2022

[infrastructure/][prod] Terraform Plan 📖 success

Show Plan ```

terraform
module.ui.azurerm_app_service_plan.plan[0]: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/serverfarms/time-tracker-ui-prod]
module.ui.azurerm_app_service.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/sites/time-tracker-ui-prod]
module.ui.azurerm_dns_cname_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Network/dnszones/timetrackerapp.ioet.com/CNAME/ui]
module.ui.azurerm_dns_txt_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Network/dnszones/timetrackerapp.ioet.com/TXT/asuid.ui.timetrackerapp.ioet.com]
module.ui.azurerm_app_service_custom_hostname_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/sites/time-tracker-ui-prod/hostNameBindings/ui.timetrackerapp.ioet.com]
module.ui.azurerm_app_service_managed_certificate.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/certificates/ui.timetrackerapp.ioet.com]
module.ui.azurerm_app_service_certificate_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/sites/time-tracker-ui-prod/hostNameBindings/ui.timetrackerapp.ioet.com|/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/certificates/ui.timetrackerapp.ioet.com]

Note: Objects have changed outside of Terraform

Terraform detected the following changes made outside of Terraform since the
last "terraform apply":

module.ui.azurerm_app_service.this has been deleted

  • resource "azurerm_app_service" "this" {

    • app_service_plan_id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/serverfarms/time-tracker-ui-prod" -> null

    • app_settings = {

      • "DOCKER_REGISTRY_SERVER_PASSWORD" = (sensitive)
      • "DOCKER_REGISTRY_SERVER_URL" = (sensitive)
      • "DOCKER_REGISTRY_SERVER_USERNAME" = (sensitive)
        } -> null

    • client_affinity_enabled = false -> null

    • client_cert_enabled = false -> null

    • client_cert_mode = "Required" -> null

    • custom_domain_verification_id = "6784E371282F6FC9E447605B5866C8A4C84A68F35143F3567B8CAA10F78A43D4" -> null

    • default_site_hostname = "time-tracker-ui-prod.azurewebsites.net" -> null

    • enabled = true -> null

    • https_only = false -> null

    • id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/sites/time-tracker-ui-prod" -> null

    • key_vault_reference_identity_id = "SystemAssigned" -> null

    • location = "westus" -> null

    • name = "time-tracker-ui-prod" -> null

    • outbound_ip_address_list = [

      • "40.112.243.46",
      • "40.118.230.174",
      • "104.42.150.243",
      • "40.118.225.132",
      • "40.112.135.83",
        ] -> null

    • outbound_ip_addresses = "40.112.243.46,40.118.230.174,104.42.150.243,40.118.225.132,40.112.135.83" -> null

    • possible_outbound_ip_address_list = [

      • "40.112.243.46",
      • "40.118.230.174",
      • "104.42.150.243",
      • "40.118.225.132",
      • "40.112.135.83",
      • "40.118.227.215",
      • "40.118.231.14",
      • "13.64.101.180",
      • "104.42.56.180",
      • "40.118.225.130",
        ] -> null

    • possible_outbound_ip_addresses = "40.112.243.46,40.118.230.174,104.42.150.243,40.118.225.132,40.112.135.83,40.118.227.215,40.118.231.14,13.64.101.180,104.42.56.180,40.118.225.130" -> null

    • resource_group_name = "time-tracker-service-prod" -> null

    • site_credential = [

      • {
        • password = "oPwaFvYSCtWye1R8v03YwnGDTur8gH47ftijn8GCbLzrr0J1ryxSrNuvFobL"
        • username = "$time-tracker-ui-prod"
          },
          ] -> null

    • auth_settings {

      • additional_login_params = {} -> null
      • allowed_external_redirect_urls = [] -> null
      • enabled = false -> null
      • token_refresh_extension_hours = 0 -> null
      • token_store_enabled = false -> null
        }

    • logs {

      • detailed_error_messages_enabled = false -> null

      • failed_request_tracing_enabled = false -> null

      • application_logs {

        • file_system_level = "Off" -> null
          }

      • http_logs {
        }
        }

    • site_config {

      • acr_use_managed_identity_credentials = false -> null

      • acr_user_managed_identity_client_id = "" -> null

      • always_on = false -> null

      • app_command_line = "" -> null

      • auto_swap_slot_name = "" -> null

      • dotnet_framework_version = "v4.0" -> null

      • ftps_state = "AllAllowed" -> null

      • health_check_path = "" -> null

      • http2_enabled = false -> null

      • ip_restriction = [] -> null

      • java_container = "" -> null

      • java_container_version = "" -> null

      • java_version = "" -> null

      • linux_fx_version = (sensitive) -> null

      • local_mysql_enabled = false -> null

      • managed_pipeline_mode = "Integrated" -> null

      • min_tls_version = "1.2" -> null

      • number_of_workers = 1 -> null

      • php_version = "" -> null

      • python_version = "" -> null

      • remote_debugging_enabled = false -> null

      • remote_debugging_version = "VS2019" -> null

      • scm_ip_restriction = [] -> null

      • scm_type = "None" -> null

      • scm_use_main_ip_restriction = false -> null

      • use_32_bit_worker_process = false -> null

      • vnet_route_all_enabled = false -> null

      • websockets_enabled = false -> null

      • windows_fx_version = "" -> null

      • cors {

        • allowed_origins = [] -> null
        • support_credentials = false -> null
          }
          }

    • source_control {

      • branch = "master" -> null
      • manual_integration = false -> null
      • rollback_enabled = false -> null
      • use_mercurial = false -> null
        }
        }

module.ui.azurerm_app_service_certificate_binding.this has been deleted

  • resource "azurerm_app_service_certificate_binding" "this" {
    • app_service_name = "time-tracker-ui-prod" -> null
    • certificate_id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/certificates/ui.timetrackerapp.ioet.com" -> null
    • hostname = "ui.timetrackerapp.ioet.com" -> null
    • hostname_binding_id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/sites/time-tracker-ui-prod/hostNameBindings/ui.timetrackerapp.ioet.com" -> null
    • id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/sites/time-tracker-ui-prod/hostNameBindings/ui.timetrackerapp.ioet.com|/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/certificates/ui.timetrackerapp.ioet.com" -> null
    • ssl_state = "SniEnabled" -> null
    • thumbprint = "041C8DABF19D208F44A0D3940D3F4E1E45235F4F" -> null
      }

module.ui.azurerm_app_service_custom_hostname_binding.this has been deleted

  • resource "azurerm_app_service_custom_hostname_binding" "this" {
    • app_service_name = "time-tracker-ui-prod" -> null
    • hostname = "ui.timetrackerapp.ioet.com" -> null
    • id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/sites/time-tracker-ui-prod/hostNameBindings/ui.timetrackerapp.ioet.com" -> null
    • resource_group_name = "time-tracker-service-prod" -> null
      }

module.ui.azurerm_app_service_managed_certificate.this has been deleted

  • resource "azurerm_app_service_managed_certificate" "this" {
    • canonical_name = "ui.timetrackerapp.ioet.com" -> null
    • custom_hostname_binding_id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/sites/time-tracker-ui-prod/hostNameBindings/ui.timetrackerapp.ioet.com" -> null
    • expiration_date = "2022-11-12T23:59:59Z" -> null
    • host_names = [
      • "ui.timetrackerapp.ioet.com",
        ] -> null
    • id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/certificates/ui.timetrackerapp.ioet.com" -> null
    • issue_date = "2022-05-12T00:00:00Z" -> null
    • issuer = "GeoTrust TLS DV RSA Mixed SHA256 2020 CA-1" -> null
    • subject_name = "ui.timetrackerapp.ioet.com" -> null
    • thumbprint = "041C8DABF19D208F44A0D3940D3F4E1E45235F4F" -> null
      }

module.ui.azurerm_app_service_plan.plan[0] has been deleted

  • resource "azurerm_app_service_plan" "plan" {

    • id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/serverfarms/time-tracker-ui-prod" -> null

    • is_xenon = false -> null

    • kind = "linux" -> null

    • location = "westus" -> null

    • maximum_elastic_worker_count = 1 -> null

    • maximum_number_of_workers = 10 -> null

    • name = "time-tracker-ui-prod" -> null

    • per_site_scaling = false -> null

    • reserved = true -> null

    • resource_group_name = "time-tracker-service-prod" -> null

    • zone_redundant = false -> null

    • sku {

      • capacity = 1 -> null
      • size = "S1" -> null
      • tier = "Standard" -> null
        }
        }

module.ui.azurerm_dns_cname_record.this has been deleted

  • resource "azurerm_dns_cname_record" "this" {
    • fqdn = "ui.timetrackerapp.ioet.com." -> null
    • id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Network/dnszones/timetrackerapp.ioet.com/CNAME/ui" -> null
    • name = "ui" -> null
    • record = "time-tracker-ui-prod.azurewebsites.net" -> null
    • resource_group_name = "time-tracker-service-prod" -> null
    • ttl = 300 -> null
    • zone_name = "timetrackerapp.ioet.com" -> null
      }

module.ui.azurerm_dns_txt_record.this has been deleted

  • resource "azurerm_dns_txt_record" "this" {

    • fqdn = "asuid.ui.timetrackerapp.ioet.com.timetrackerapp.ioet.com." -> null

    • id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Network/dnszones/timetrackerapp.ioet.com/TXT/asuid.ui.timetrackerapp.ioet.com" -> null

    • name = "asuid.ui.timetrackerapp.ioet.com" -> null

    • resource_group_name = "time-tracker-service-prod" -> null

    • ttl = 300 -> null

    • zone_name = "timetrackerapp.ioet.com" -> null

    • record {

      • value = "6784E371282F6FC9E447605B5866C8A4C84A68F35143F3567B8CAA10F78A43D4" -> null
        }
        }

Unless you have made equivalent changes to your configuration, or ignored the
relevant attributes using ignore_changes, the following plan may include
actions to undo or respond to these changes.

─────────────────────────────────────────────────────────────────────────────

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:

  • create

Terraform will perform the following actions:

module.ui.azurerm_app_service.this will be created

  • resource "azurerm_app_service" "this" {

    • app_service_plan_id = (known after apply)

    • app_settings = {

      • "DOCKER_REGISTRY_SERVER_PASSWORD" = (sensitive)
      • "DOCKER_REGISTRY_SERVER_URL" = (sensitive)
      • "DOCKER_REGISTRY_SERVER_USERNAME" = (sensitive)
        }

    • client_affinity_enabled = false

    • client_cert_enabled = false

    • client_cert_mode = (known after apply)

    • custom_domain_verification_id = (known after apply)

    • default_site_hostname = (known after apply)

    • enabled = true

    • https_only = false

    • id = (known after apply)

    • key_vault_reference_identity_id = (known after apply)

    • location = "westus"

    • name = "time-tracker-ui-prod"

    • outbound_ip_address_list = (known after apply)

    • outbound_ip_addresses = (known after apply)

    • possible_outbound_ip_address_list = (known after apply)

    • possible_outbound_ip_addresses = (known after apply)

    • resource_group_name = "time-tracker-service-prod"

    • site_credential = (known after apply)

    • auth_settings {

      • additional_login_params = (known after apply)

      • allowed_external_redirect_urls = (known after apply)

      • default_provider = (known after apply)

      • enabled = (known after apply)

      • issuer = (known after apply)

      • runtime_version = (known after apply)

      • token_refresh_extension_hours = (known after apply)

      • token_store_enabled = (known after apply)

      • unauthenticated_client_action = (known after apply)

      • active_directory {

        • allowed_audiences = (known after apply)
        • client_id = (known after apply)
        • client_secret = (sensitive value)
          }

      • facebook {

        • app_id = (known after apply)
        • app_secret = (sensitive value)
        • oauth_scopes = (known after apply)
          }

      • google {

        • client_id = (known after apply)
        • client_secret = (sensitive value)
        • oauth_scopes = (known after apply)
          }

      • microsoft {

        • client_id = (known after apply)
        • client_secret = (sensitive value)
        • oauth_scopes = (known after apply)
          }

      • twitter {

        • consumer_key = (known after apply)
        • consumer_secret = (sensitive value)
          }
          }

    • connection_string {

      • name = (known after apply)
      • type = (known after apply)
      • value = (sensitive value)
        }

    • identity {

      • identity_ids = (known after apply)
      • principal_id = (known after apply)
      • tenant_id = (known after apply)
      • type = (known after apply)
        }

    • logs {

      • detailed_error_messages_enabled = (known after apply)

      • failed_request_tracing_enabled = (known after apply)

      • application_logs {

        • file_system_level = (known after apply)

        • azure_blob_storage {

          • level = (known after apply)
          • retention_in_days = (known after apply)
          • sas_url = (sensitive value)
            }
            }

      • http_logs {

        • azure_blob_storage {

          • retention_in_days = (known after apply)
          • sas_url = (sensitive value)
            }

        • file_system {

          • retention_in_days = (known after apply)
          • retention_in_mb = (known after apply)
            }
            }
            }

    • site_config {

      • acr_use_managed_identity_credentials = false

      • always_on = false

      • dotnet_framework_version = "v4.0"

      • ftps_state = (known after apply)

      • http2_enabled = false

      • ip_restriction = (known after apply)

      • linux_fx_version = (sensitive)

      • local_mysql_enabled = (known after apply)

      • managed_pipeline_mode = (known after apply)

      • min_tls_version = (known after apply)

      • number_of_workers = (known after apply)

      • remote_debugging_enabled = false

      • remote_debugging_version = (known after apply)

      • scm_ip_restriction = (known after apply)

      • scm_type = (known after apply)

      • scm_use_main_ip_restriction = false

      • vnet_route_all_enabled = (known after apply)

      • websockets_enabled = (known after apply)

      • windows_fx_version = (known after apply)

      • cors {

        • allowed_origins = (known after apply)
        • support_credentials = (known after apply)
          }
          }

    • source_control {

      • branch = (known after apply)
      • manual_integration = (known after apply)
      • repo_url = (known after apply)
      • rollback_enabled = (known after apply)
      • use_mercurial = (known after apply)
        }

    • storage_account {

      • access_key = (sensitive value)
      • account_name = (known after apply)
      • mount_path = (known after apply)
      • name = (known after apply)
      • share_name = (known after apply)
      • type = (known after apply)
        }
        }

module.ui.azurerm_app_service_certificate_binding.this will be created

  • resource "azurerm_app_service_certificate_binding" "this" {
    • app_service_name = (known after apply)
    • certificate_id = (known after apply)
    • hostname = (known after apply)
    • hostname_binding_id = (known after apply)
    • id = (known after apply)
    • ssl_state = "SniEnabled"
    • thumbprint = (known after apply)
      }

module.ui.azurerm_app_service_custom_hostname_binding.this will be created

  • resource "azurerm_app_service_custom_hostname_binding" "this" {
    • app_service_name = "time-tracker-ui-prod"
    • hostname = "ui.timetrackerapp.ioet.com"
    • id = (known after apply)
    • resource_group_name = "time-tracker-service-prod"
    • ssl_state = (known after apply)
    • thumbprint = (known after apply)
    • virtual_ip = (known after apply)
      }

module.ui.azurerm_app_service_managed_certificate.this will be created

  • resource "azurerm_app_service_managed_certificate" "this" {
    • canonical_name = (known after apply)
    • custom_hostname_binding_id = (known after apply)
    • expiration_date = (known after apply)
    • friendly_name = (known after apply)
    • host_names = (known after apply)
    • id = (known after apply)
    • issue_date = (known after apply)
    • issuer = (known after apply)
    • subject_name = (known after apply)
    • thumbprint = (known after apply)
      }

module.ui.azurerm_app_service_plan.plan[0] will be created

  • resource "azurerm_app_service_plan" "plan" {

    • id = (known after apply)

    • kind = "Linux"

    • location = "westus"

    • maximum_elastic_worker_count = (known after apply)

    • maximum_number_of_workers = (known after apply)

    • name = "time-tracker-ui-prod"

    • reserved = true

    • resource_group_name = "time-tracker-service-prod"

    • sku {

      • capacity = (known after apply)
      • size = "S1"
      • tier = "Standard"
        }
        }

module.ui.azurerm_dns_cname_record.this will be created

  • resource "azurerm_dns_cname_record" "this" {
    • fqdn = (known after apply)
    • id = (known after apply)
    • name = "ui"
    • record = (known after apply)
    • resource_group_name = "time-tracker-service-prod"
    • ttl = 300
    • zone_name = "timetrackerapp.ioet.com"
      }

module.ui.azurerm_dns_txt_record.this will be created

  • resource "azurerm_dns_txt_record" "this" {

    • fqdn = (known after apply)

    • id = (known after apply)

    • name = "asuid.ui.timetrackerapp.ioet.com"

    • resource_group_name = "time-tracker-service-prod"

    • ttl = 300

    • zone_name = "timetrackerapp.ioet.com"

    • record {

      • value = (known after apply)
        }
        }

Plan: 7 to add, 0 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

</details>
*Pusher: @wilc0519, Action: `pull_request`*

@github-actions
Copy link

github-actions bot commented Jul 5, 2022

[infrastructure/][stage] Terraform Plan 📖 success

Show Plan ```

terraform
module.ui.azurerm_app_service_plan.plan[0]: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/serverfarms/time-tracker-ui-stage]
module.ui.azurerm_app_service.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage]
module.ui.azurerm_dns_txt_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Network/dnszones/timetrackerapp.stage.ioet.com/TXT/asuid.ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_app_service_custom_hostname_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage/hostNameBindings/ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_dns_cname_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Network/dnszones/timetrackerapp.stage.ioet.com/CNAME/ui]
module.ui.azurerm_app_service_managed_certificate.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/certificates/ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_app_service_certificate_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage/hostNameBindings/ui.timetrackerapp.stage.ioet.com|/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/certificates/ui.timetrackerapp.stage.ioet.com]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place

Terraform will perform the following actions:

module.ui.azurerm_app_service.this will be updated in-place

~ resource "azurerm_app_service" "this" {
id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage"
name = "time-tracker-ui-stage"
tags = {}
# (17 unchanged attributes hidden)

  ~ site_config {
      ~ linux_fx_version                     = (sensitive)
        # (29 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

    # (3 unchanged blocks hidden)
}

Plan: 0 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

</details>
*Pusher: @wilc0519, Action: `pull_request`*

@github-actions
Copy link

github-actions bot commented Jul 5, 2022

[infrastructure/][prod] Terraform Plan 📖 failure

Show Plan ```

terraform

</details>
*Pusher: @wilc0519, Action: `pull_request`*

@github-actions
Copy link

github-actions bot commented Jul 5, 2022

[infrastructure/][stage] Terraform Plan 📖 success

Show Plan ```

terraform
module.ui.azurerm_app_service_plan.plan[0]: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/serverfarms/time-tracker-ui-stage]
module.ui.azurerm_app_service.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage]
module.ui.azurerm_dns_txt_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Network/dnszones/timetrackerapp.stage.ioet.com/TXT/asuid.ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_dns_cname_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Network/dnszones/timetrackerapp.stage.ioet.com/CNAME/ui]
module.ui.azurerm_app_service_custom_hostname_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage/hostNameBindings/ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_app_service_managed_certificate.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/certificates/ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_app_service_certificate_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage/hostNameBindings/ui.timetrackerapp.stage.ioet.com|/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/certificates/ui.timetrackerapp.stage.ioet.com]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place

Terraform will perform the following actions:

module.ui.azurerm_app_service.this will be updated in-place

~ resource "azurerm_app_service" "this" {
id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage"
name = "time-tracker-ui-stage"
tags = {}
# (17 unchanged attributes hidden)

  ~ site_config {
      ~ linux_fx_version                     = (sensitive)
        # (29 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

    # (3 unchanged blocks hidden)
}

Plan: 0 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

</details>
*Pusher: @wilc0519, Action: `pull_request`*

@github-actions
Copy link

github-actions bot commented Jul 5, 2022

[infrastructure/][prod] Terraform Plan 📖 failure

Show Plan ```

terraform

</details>
*Pusher: @wilc0519, Action: `pull_request`*

jimmyjaramillo
jimmyjaramillo reviewed Jul 5, 2022
View reviewed changes
src/app/modules/reports/components/time-entries-table/time-entries-table.component.ts
this.totalTimeSelected = this.totalTimeSelected.subtract(duration);
}
let daysTotalInHours = this.totalTimeSelected.days() * 24;
this.resultSumEntriesSelected.hours = this.totalTimeSelected.hours() + daysTotalInHours;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

daysTotalInHours is never reassigned, use 'const' instead of 'let'.

jimmyjaramillo
jimmyjaramillo reviewed Jul 5, 2022
View reviewed changes
src/app/modules/reports/components/time-entries-table/time-entries-table.component.ts Outdated
sumHoursEntriesSelected(entry: Entry, checked: boolean){
this.resultSumEntriesSelected = new TotalHours();
const duration = moment.duration(moment(entry.end_date).diff(moment(entry.start_date)));
if(checked){
Copy link
Contributor

@jimmyjaramillo jimmyjaramillo Jul 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can change this code section? , for example:
this.totalTimeSelected = checked ? this.totalTimeSelected.add(duration) : this.totalTimeSelected.subtract(duration);

@github-actions
Copy link

github-actions bot commented Jul 6, 2022

[infrastructure/][stage] Terraform Plan 📖 failure

Show Plan ```

terraform

</details>
*Pusher: @wilc0519, Action: `pull_request`*

@github-actions
Copy link

github-actions bot commented Jul 6, 2022

[infrastructure/][prod] Terraform Plan 📖 failure

Show Plan ```

terraform
Releasing state lock. This may take a few moments...

</details>
*Pusher: @wilc0519, Action: `pull_request`*

@jimmyjaramillo jimmyjaramillo self-requested a review July 6, 2022 15:19
@github-actions
Copy link

[infrastructure/][stage] Terraform Plan 📖 success

Show Plan ```

terraform
module.ui.azurerm_app_service_plan.plan[0]: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/serverfarms/time-tracker-ui-stage]
module.ui.azurerm_app_service.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage]
module.ui.azurerm_app_service_custom_hostname_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage/hostNameBindings/ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_dns_txt_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Network/dnszones/timetrackerapp.stage.ioet.com/TXT/asuid.ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_dns_cname_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Network/dnszones/timetrackerapp.stage.ioet.com/CNAME/ui]
module.ui.azurerm_app_service_managed_certificate.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/certificates/ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_app_service_certificate_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage/hostNameBindings/ui.timetrackerapp.stage.ioet.com|/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/certificates/ui.timetrackerapp.stage.ioet.com]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place

Terraform will perform the following actions:

module.ui.azurerm_app_service.this will be updated in-place

~ resource "azurerm_app_service" "this" {
id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage"
name = "time-tracker-ui-stage"
tags = {}
# (17 unchanged attributes hidden)

  ~ site_config {
      ~ linux_fx_version                     = (sensitive)
        # (29 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

    # (3 unchanged blocks hidden)
}

Plan: 0 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

</details>
*Pusher: @wilc0519, Action: `pull_request`*

@github-actions
Copy link

[infrastructure/][prod] Terraform Plan 📖 success

Show Plan ```

terraform

</details>
*Pusher: @wilc0519, Action: `pull_request`*

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

[infrastructure/][stage] Terraform Plan 📖 success

Show Plan ```

terraform
module.ui.azurerm_app_service_plan.plan[0]: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/serverfarms/time-tracker-ui-stage]
module.ui.azurerm_app_service.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage]
module.ui.azurerm_dns_txt_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Network/dnszones/timetrackerapp.stage.ioet.com/TXT/asuid.ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_dns_cname_record.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Network/dnszones/timetrackerapp.stage.ioet.com/CNAME/ui]
module.ui.azurerm_app_service_custom_hostname_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage/hostNameBindings/ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_app_service_managed_certificate.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/certificates/ui.timetrackerapp.stage.ioet.com]
module.ui.azurerm_app_service_certificate_binding.this: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage/hostNameBindings/ui.timetrackerapp.stage.ioet.com|/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/certificates/ui.timetrackerapp.stage.ioet.com]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place

Terraform will perform the following actions:

module.ui.azurerm_app_service.this will be updated in-place

~ resource "azurerm_app_service" "this" {
id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage"
name = "time-tracker-ui-stage"
tags = {}
# (17 unchanged attributes hidden)

  ~ site_config {
      ~ linux_fx_version                     = (sensitive)
        # (29 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

    # (3 unchanged blocks hidden)
}

Plan: 0 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

</details>
*Pusher: @wilc0519, Action: `pull_request`*

@github-actions
Copy link

[infrastructure/][prod] Terraform Plan 📖 success

Show Plan ```

terraform

</details>
*Pusher: @wilc0519, Action: `pull_request`*

@wilc0519 wilc0519 merged commit 9faff9b into master Jul 18, 2022
@wilc0519 wilc0519 deleted the TTA-29-On-Reports-page-allow-selecting-multiple-time-entries-and-show-total-of-hours-of-selected-entries branch July 18, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@jimmyjaramillo jimmyjaramillo jimmyjaramillo approved these changes

@andresacg andresacg andresacg approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wilc0519 @jimmyjaramillo @andresacg