-
Notifications
You must be signed in to change notification settings - Fork 1
change default sorting in date range selection from monday to sunday #880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change default sorting in date range selection from monday to sunday #880
Conversation
[infrastructure/][stage] Terraform Plan 📖
|
[infrastructure/][prod] Terraform Plan 📖
|
Codecov Report
@@ Coverage Diff @@
## master #880 +/- ##
==========================================
+ Coverage 97.48% 97.61% +0.12%
==========================================
Files 107 109 +2
Lines 2430 2469 +39
Branches 203 204 +1
==========================================
+ Hits 2369 2410 +41
+ Misses 23 21 -2
Partials 38 38
Continue to review full report at Codecov.
|
[infrastructure/][stage] Terraform Plan 📖
|
[infrastructure/][prod] Terraform Plan 📖
|
@@ -7,6 +7,9 @@ import * as entryActions from '../../../time-clock/store/entry.actions'; | |||
import {Store} from '@ngrx/store'; | |||
import {EntryState} from '../../../time-clock/store/entry.reducer'; | |||
import * as moment from 'moment'; | |||
import { DateAdapter } from '@angular/material/core'; | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove line break
@@ -8,12 +8,16 @@ import { InputDateComponent } from '../../../shared/components/input-date/input- | |||
import * as entryActions from '../../../time-clock/store/entry.actions'; | |||
import * as moment from 'moment'; | |||
import { SimpleChange } from '@angular/core'; | |||
import { DateAdapter } from '@angular/material/core'; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove line break
src/environments/environment.ts
Outdated
@@ -4,7 +4,7 @@ | |||
|
|||
export const environment = { | |||
production: false, | |||
timeTrackerApiUrl: 'http://localhost:7071/api', | |||
timeTrackerApiUrl: 'https://0390-2800-4f0-546-4680-b5ef-416e-decc-9774.ngrok.io/api', | |||
stackexchangeApiUrl: 'https://api.stackexchange.com', | |||
}; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove line break
[infrastructure/][stage] Terraform Plan 📖
|
[infrastructure/][prod] Terraform Plan 📖
|
https://github.com/ioet/time-tracker-ui into TT-33-load-data-from-monday-to-sunday-on-reports-page
[infrastructure/][stage] Terraform Plan 📖
|
[infrastructure/][prod] Terraform Plan 📖
|
Kudos, SonarCloud Quality Gate passed!
|
[infrastructure/][stage] Terraform Plan 📖
|
[infrastructure/][prod] Terraform Plan 📖
|
src/environments/environment.ts
Outdated
@@ -4,7 +4,7 @@ | |||
|
|||
export const environment = { | |||
production: false, | |||
timeTrackerApiUrl: 'http://localhost:7071/api', | |||
timeTrackerApiUrl: 'https://0390-2800-4f0-546-4680-b5ef-416e-decc-9774.ngrok.io/api', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be localhost again?
this.reportForm = new FormGroup({ | ||
startDate: this.startDate, | ||
endDate: this.endDate | ||
}); | ||
date.getFirstDayOfWeek = () => 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs a test
No description provided.