#86 Implement no-unused-variable rule

src/app/modules/activities-management/components/activity-list/activity-list.component.ts

@@ -1,4 +1,4 @@
-import { Input, OnInit } from '@angular/core';
+import { OnInit } from '@angular/core';
 import { Component } from '@angular/core';
 import { Store, select } from '@ngrx/store';
 

src/app/modules/activities-management/components/create-activity/create-activity.component.ts

@@ -1,9 +1,8 @@
 import { FormBuilder, Validators, FormGroup } from '@angular/forms';
-import { Component, Input, EventEmitter, Output } from '@angular/core';
-import { Store, select } from '@ngrx/store';
-import { Activity } from '../../../shared/models';
+import { Component } from '@angular/core';
+import { Store } from '@ngrx/store';
 import { ActivityState } from './../../store/activity-management.reducers';
-import { CreateActivity, allActivities } from '../../store';
+import { CreateActivity } from '../../store';
 
 @Component({
   selector: 'app-create-activity',

src/app/modules/activities-management/pages/activities-management.component.ts

@@ -1,14 +1,12 @@
 import { Component, OnInit } from '@angular/core';
-import { ActivityService } from '../services/activity.service';
-import { Activity } from '../../shared/models';
 
 @Component({
   selector: 'app-activities-management',
   templateUrl: './activities-management.component.html',
   styleUrls: ['./activities-management.component.scss'],
 })
 export class ActivitiesManagementComponent implements OnInit {
-  constructor(private activityService: ActivityService) {}
+  constructor() {}
 
   ngOnInit(): void {}
 }

src/app/modules/activities-management/services/activity.service.ts

@@ -1,5 +1,5 @@
 import { Injectable } from '@angular/core';
-import { HttpClient, HttpHeaders } from '@angular/common/http';
+import { HttpClient } from '@angular/common/http';
 import { Observable } from 'rxjs';
 
 import { environment } from './../../../../environments/environment';

src/app/modules/activities-management/store/activity-management.reducers.spec.ts

@@ -5,7 +5,6 @@ import {
   CreateActivitySuccess,
   CreateActivityFail,
   CreateActivity,
-  DeleteActivity,
   DeleteActivitySuccess,
 } from './activity-management.actions';
 import { LoadActivitiesSuccess } from './activity-management.actions';

src/app/modules/login/services/azure.ad.b2c.service.spec.ts

@@ -4,30 +4,24 @@ import { UserAgentApplication, Account } from 'msal';
 
 describe('AzureAdB2CService', () => {
   let service: AzureAdB2CService;
-  const msalStub = {
-    loginPopup() {
-      return {};
-    }
-  };
 
   beforeEach(() => {
     TestBed.configureTestingModule({
-      imports: []
+      imports: [],
     });
     service = TestBed.inject(AzureAdB2CService);
   });
 
-  it('should be created', inject([AzureAdB2CService],
-    ( apiService: AzureAdB2CService) => {
-      expect(apiService).toBeTruthy();
+  it('should be created', inject([AzureAdB2CService], (apiService: AzureAdB2CService) => {
+    expect(apiService).toBeTruthy();
   }));
 
   it('on signIn should call msal loginPopup', () => {
-    spyOn(UserAgentApplication.prototype, 'loginPopup').and.returnValue((
+    spyOn(UserAgentApplication.prototype, 'loginPopup').and.returnValue(
       new Promise((resolve) => {
-          resolve();
+        resolve();
       })
-    ));
+    );
     service.signIn();
     expect(UserAgentApplication.prototype.loginPopup).toHaveBeenCalled();
   });
@@ -47,7 +41,7 @@ describe('AzureAdB2CService', () => {
       idToken: {},
       idTokenClaims: {},
       sid: 'abc',
-      environment: 'abc'
+      environment: 'abc',
     };
     spyOn(UserAgentApplication.prototype, 'getAccount').and.returnValues(account);
 
@@ -66,7 +60,7 @@ describe('AzureAdB2CService', () => {
       idToken: {},
       idTokenClaims: {},
       sid: 'abc',
-      environment: 'abc'
+      environment: 'abc',
     };
     spyOn(UserAgentApplication.prototype, 'getAccount').and.returnValue(account);
 
@@ -82,5 +76,4 @@ describe('AzureAdB2CService', () => {
     expect(UserAgentApplication.prototype.getAccount).toHaveBeenCalled();
     expect(isLogin).toEqual(false);
   });
-
 });

src/app/modules/reports/pages/reports.component.spec.ts

@@ -15,9 +15,8 @@ describe('ReportsComponent', () => {
 
   beforeEach(async(() => {
     TestBed.configureTestingModule({
-      declarations: [ ReportsComponent ]
-    })
-    .compileComponents();
+      declarations: [ReportsComponent],
+    }).compileComponents();
   }));
 
   beforeEach(() => {
@@ -30,13 +29,12 @@ describe('ReportsComponent', () => {
     expect(component).toBeTruthy();
   });
 
-  it('should have p tag as \'reports works!\'', async(() => {
+  it('should have p tag as "reports works!"', async(() => {
     // tslint:disable-next-line: no-shadowed-variable
-    const { app, fixture } = setup();
+    const { fixture } = setup();
     fixture.detectChanges();
     const compile = fixture.debugElement.nativeElement;
     const ptag = compile.querySelector('p');
     expect(ptag.textContent).toBe('reports works!');
   }));
-
 });

src/app/modules/shared/components/clock/clock.component.ts

@@ -1,13 +1,12 @@
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 import { interval } from 'rxjs';
 
 @Component({
   selector: 'app-clock',
   templateUrl: './clock.component.html',
-  styleUrls: ['./clock.component.scss']
+  styleUrls: ['./clock.component.scss'],
 })
 export class ClockComponent {
-
   currentDate: Date = new Date();
   hour: number;
   minutes: number;
@@ -20,15 +19,15 @@ export class ClockComponent {
     setTimeout(() => {
       this.displayTime = true;
     }, 3000);
-   }
+  }
 
-   showClock() {
+  showClock() {
     const timenInterval = interval(1000);
-    timenInterval.subscribe( (data) => {
+    timenInterval.subscribe((data) => {
       this.currentDate = new Date();
       this.hour = this.currentDate.getHours();
       this.minutes = this.currentDate.getMinutes();
       this.seconds = this.currentDate.getSeconds();
     });
-   }
+  }
 }

src/app/modules/shared/pipes/group-by-date/group-by-date.pipe.spec.ts

@@ -1,5 +1,4 @@
 import { GroupByDatePipe } from './group-by-date.pipe';
-import { Pipe } from '@angular/core';
 
 describe('GroupByDatePipe', () => {
   it('create an instance', () => {
@@ -24,7 +23,7 @@ describe('GroupByDatePipe', () => {
         activity: 'development',
         technology: 'Angular, TypeScript',
         comments: 'No comments',
-        ticket: 'EY-25'
+        ticket: 'EY-25',
       },
       {
         id: 'entry_2',
@@ -34,7 +33,7 @@ describe('GroupByDatePipe', () => {
         activity: 'development',
         technology: 'Angular, TypeScript',
         comments: 'No comments',
-        ticket: 'EY-38'
+        ticket: 'EY-38',
       },
       {
         id: 'entry_3',
@@ -44,7 +43,7 @@ describe('GroupByDatePipe', () => {
         activity: 'development',
         technology: 'Angular, TypeScript',
         comments: 'No comments',
-        ticket: 'EY-225'
+        ticket: 'EY-225',
       },
       {
         id: 'entry_4',
@@ -54,7 +53,7 @@ describe('GroupByDatePipe', () => {
         activity: 'development',
         technology: 'Angular, TypeScript',
         comments: 'No comments',
-        ticket: 'EY-89'
+        ticket: 'EY-89',
       },
       {
         id: 'entry_5',
@@ -64,8 +63,8 @@ describe('GroupByDatePipe', () => {
         activity: 'development',
         technology: 'Angular, TypeScript',
         comments: 'No comments',
-        ticket: 'EY-59'
-      }
+        ticket: 'EY-59',
+      },
     ];
     const pipe = new GroupByDatePipe();
     const result = pipe.transform(entryList);

src/app/modules/time-entries/pages/time-entries.component.spec.ts

@@ -5,7 +5,7 @@ import {
   MonthPickerComponent,
   DetailsFieldsComponent,
   EmptyStateComponent,
-  ModalComponent
+  ModalComponent,
 } from '../../shared/components';
 import { GroupByDatePipe } from '../../shared/pipes';
 import { TimeEntriesComponent } from './time-entries.component';
@@ -21,16 +21,9 @@ describe('TimeEntriesComponent', () => {
     activity: 'development',
     technology: 'Angular, TypeScript',
     comments: 'No comments',
-    ticket: 'EY-25'
+    ticket: 'EY-25',
   };
 
-  function setup() {
-    // tslint:disable-next-line: no-shadowed-variable
-    const fixture = TestBed.createComponent(TimeEntriesComponent);
-    const app = fixture.debugElement.componentInstance;
-    return { fixture, app };
-  }
-
   beforeEach(async(() => {
     TestBed.configureTestingModule({
       declarations: [
@@ -39,14 +32,10 @@ describe('TimeEntriesComponent', () => {
         GroupByDatePipe,
         ModalComponent,
         MonthPickerComponent,
-        TimeEntriesComponent
+        TimeEntriesComponent,
       ],
-      imports: [
-        FormsModule,
-        ReactiveFormsModule
-      ]
-    })
-    .compileComponents();
+      imports: [FormsModule, ReactiveFormsModule],
+    }).compileComponents();
   }));
 
   beforeEach(() => {

tslint.json

@@ -6,6 +6,9 @@
     "deprecation": {
       "severity": "warning"
     },
+    "no-unused-variable": {
+      "severity": "warning"
+    },
     "component-class-suffix": true,
     "contextual-lifecycle": true,
     "directive-class-suffix": true,
@@ -88,4 +91,4 @@
   "rulesDirectory": [
     "codelyzer"
   ]
-}
+}