Skip to content

Implementing ordered activities test #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 27, 2022
Merged

Implementing ordered activities test #875

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0a25087
Implementing ordered activities test
sbateca May 24, 2022
1b03641
Implementing form status before doing submit
sbateca May 24, 2022
463d5e6
Implementing test for allActiveActivities selector
sbateca May 24, 2022
a686a21
Implementing tests when the date value is null, undefined and empty
sbateca May 24, 2022
9af68be
TT-665 clean code
May 25, 2022
b6b7058
TT-665 clean code
May 25, 2022
d662919
TT-665 clean code
May 25, 2022
385a8ae
Implementing test when the ngOnChanges method is the first change, th…
sbateca May 25, 2022
3d23d68
TT-665 clean code
May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
TT-665 clean code
  • Loading branch information
Nicole Garcia committed May 25, 2022
commit 3d23d689083b8d2b1d01d22f1a5de6045c651638
4 changes: 3 additions & 1 deletion src/app/modules/reports/components/time-range-form/time-range.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,10 @@ describe('Reports Page', () => {
});

it('triggers onSubmit with the form status valid', () => {
const valid = component.reportForm.valid;
spyOn(component, 'onSubmit');
let valid = component.reportForm.valid;


component.setInitialDataOnScreen();

expect(valid).toBeTruthy();
Expand Down
9 changes: 5 additions & 4 deletions src/app/modules/time-clock/components/entry-fields/entry-fields.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ describe('EntryFieldsComponent', () => {
});

it('activites are ordered using the payload of the action', () => {
const listActivities = [
const activities = [
{
id: '001',
name: 'Meeting',
Expand All @@ -380,7 +380,7 @@ describe('EntryFieldsComponent', () => {
},
];

const listActivitiesOrdered = [
const activitiesOrdered = [
{
id: '002',
name: 'ABC',
Expand All @@ -397,15 +397,16 @@ describe('EntryFieldsComponent', () => {
description: 'Some description'
},
];

const actionSubject = TestBed.inject(ActionsSubject) as ActionsSubject;
const action = {
type: ActivityManagementActionTypes.LOAD_ACTIVITIES_SUCCESS,
payload: listActivities,
payload: activities,
};

actionSubject.next(action);

expect(component.activities).toEqual(listActivitiesOrdered);
expect(component.activities).toEqual(activitiesOrdered);
});

it('LoadActiveEntry is dispatchen after LOAD_ACTIVITIES_SUCCESS', () => {
Expand Down