Skip to content
Prev Previous commit
Next Next commit
Adjust to split the docker image base of dev and test
  • Loading branch information
sbateca committed May 10, 2022
commit 610385ab3daf47d5e8f2f5bd8f643e45ac9274dc
11 changes: 6 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,17 @@ help: ## Show this help message.
@grep --no-filename -E '^[a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | \
sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}'

.PHONY: build_dev
build_dev: ## Create docker image with dependencies needed for development.
docker-compose build timetracker_ui_dev
.PHONY: build
build: ## Create docker image with dependencies needed for development.
docker-compose build timetracker_ui

.PHONY: cleanup
cleanup: ## Delete image timetracker_ui
docker rmi timetracker_ui

.PHONY: run
run: ## Execute timetracker_ui dev docker containe.
docker-compose up -d timetracker_ui_dev
docker-compose up -d timetracker_ui

.PHONY: logs
logs: ## Show logs of timetracker_ui.
Expand All @@ -40,7 +40,8 @@ remove: ## Delete container timetracker_ui.

.PHONY: test
test: ## Run all tests on docker container timetracker_ui at the CLI.
docker-compose -f docker-compose.yml up -d
docker-compose build timetracker_ui
docker-compose up -d timetracker_ui
docker exec timetracker_ui bash -c "npm run ci-test"

.PHONY: testdev
Expand Down
12 changes: 7 additions & 5 deletions docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
version: '3.9'
services:
timetracker_ui_dev:
container_name: timetracker_ui_dev
image: timetracker_ui_dev
timetracker_ui:
container_name: timetracker_ui
image: timetracker_ui
build:
context: .
dockerfile: ./Docker/dev.Dockerfile
Expand Down Expand Up @@ -46,11 +46,13 @@ services:

timetracker_ui_test:
container_name: timetracker_ui_test
image: timetracker_ui_test
image: timetracker_ui
build:
# target: production
context: .
dockerfile: ./Docker/test.Dockerfile
dockerfile:
./Docker/dev.Dockerfile
./Docker/test.Dockerfile
ports:
- 4200:4200
- 9876:9876
Expand Down